From: Arjan van de Ven <arjan@infradead.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH, RFC] Driver for reading HP laptop LCD brightness
Date: Sun, 05 Feb 2006 15:27:26 +0100 [thread overview]
Message-ID: <1139149647.3131.26.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060205135517.GA21795@srcf.ucam.org>
On Sun, 2006-02-05 at 13:55 +0000, Matthew Garrett wrote:
> + if (enable==0) {
> + return snprintf(buf, PAGE_SIZE, "NA\n");
> + }
> +
> + disable_irq(8);
> +
> + outb(0x97, 0x72);
> + value = inb(0x73);
> +
> + enable_irq(8);
> +
disable_irq() and enable_irq() are really really evil. Are you sure you
need these? To me on first sight it looks like a bug (think of shared
interrupts for example), can you explain what you are trying to achieve
with these?
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2006-02-05 14:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-05 13:55 Matthew Garrett
2006-02-05 14:27 ` Arjan van de Ven [this message]
2006-02-05 14:34 ` Matthew Garrett
2006-02-05 14:41 ` Arjan van de Ven
2006-02-05 14:45 ` Matthew Garrett
2006-02-05 21:49 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139149647.3131.26.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®