From: Arthur Othieno <apgo@patchbomb.org>
To: akpm@osdl.org
Cc: Arthur Othieno <apgo@patchbomb.org>,
vandrove@vc.cvut.cz, linux-kernel@vger.kernel.org
Subject: [PATCH] matroxfb: simply return what i2c_add_driver() does
Date: Sat, 11 Feb 2006 06:00:34 -0500 [thread overview]
Message-ID: <11396556342192-git-send-email-apgo@patchbomb.org> (raw)
In-Reply-To:
insmod will tell us when the module failed to load. We do no further
processing on the return from i2c_add_driver(), so just return what
i2c_add_driver() did, instead of storing it.
Add __init/__exit annotations while we're at it.
Signed-off-by: Arthur Othieno <apgo@patchbomb.org>
---
Andrew, originally sent 12/19/05. No notification from mm-commits of
patch being accepted/dropped. Assuming it got lost along the way? ;-)
drivers/video/matrox/matroxfb_maven.c | 17 +++++------------
1 files changed, 5 insertions(+), 12 deletions(-)
3d7e2f6d53ac04029f02e1ce7b966f3521617447
diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c
index 6019710..531a0c3 100644
--- a/drivers/video/matrox/matroxfb_maven.c
+++ b/drivers/video/matrox/matroxfb_maven.c
@@ -1297,20 +1297,13 @@ static struct i2c_driver maven_driver={
.detach_client = maven_detach_client,
};
-/* ************************** */
-
-static int matroxfb_maven_init(void) {
- int err;
-
- err = i2c_add_driver(&maven_driver);
- if (err) {
- printk(KERN_ERR "maven: Maven driver failed to register (%d).\n", err);
- return err;
- }
- return 0;
+static int __init matroxfb_maven_init(void)
+{
+ return i2c_add_driver(&maven_driver);
}
-static void matroxfb_maven_exit(void) {
+static void __exit matroxfb_maven_exit(void)
+{
i2c_del_driver(&maven_driver);
}
--
1.1.5
next reply other threads:[~2006-02-11 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-11 11:00 Arthur Othieno [this message]
2006-02-11 13:53 ` Jean Delvare
2006-02-11 14:39 ` Arthur Othieno
-- strict thread matches above, loose matches on Subject: below --
2005-12-20 3:25 Arthur Othieno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11396556342192-git-send-email-apgo@patchbomb.org \
--to=apgo@patchbomb.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vandrove@vc.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome