From: Arjan van de Ven <arjan@infradead.org>
To: Jason Baron <jbaron@redhat.com>
Cc: Paul Fulghum <paulkf@microgate.com>,
Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"jesper.juhl@gmail.com" <jesper.juhl@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH] tty reference count fix
Date: Tue, 14 Feb 2006 22:46:29 +0100 [thread overview]
Message-ID: <1139953590.4117.23.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.61.0602131747570.19384@dhcp83-105.boston.redhat.com>
>
> patch looks good to me. Or you could even drop the tty_sem completely from
> the release_dev path (patch below) since lock_kernel() is held in both
> tty_open() and the release_dev paths() (and there is no sleeping b/w
> setting the tty_closing flag and setting the TTY_CLOSING bit).
that's the wrong direction.. the idea is to first put new locking under
the BKL layer.. and at the end pull the BKL entirely.. The BKL isn't a
good lock.
prev parent reply other threads:[~2006-02-14 21:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-13 20:13 Paul Fulghum
2006-02-13 22:15 ` Jesper Juhl
2006-02-13 23:21 ` Paul Fulghum
2006-02-13 22:51 ` Jason Baron
2006-02-13 23:45 ` Paul Fulghum
2006-02-14 0:20 ` Paul Fulghum
2006-02-14 21:46 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1139953590.4117.23.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jbaron@redhat.com \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulkf@microgate.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®