From: Vidya Sagar <vidyas@nvidia.com>
To: Joe Perches <joe@perches.com>
Cc: "linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"bhelgaas@google.com" <bhelgaas@google.com>,
"wangyijing@huawei.com" <wangyijing@huawei.com>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"jason@lakedaemon.net" <jason@lakedaemon.net>,
"will.deacon@arm.com" <will.deacon@arm.com>,
"Stephen Warren" <swarren@nvidia.com>,
Krishna Thota <kthota@nvidia.com>,
"sagar.tv@gmail.com" <sagar.tv@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] ARM: fix debug prints relevant to PCI devices
Date: Fri, 6 Jun 2014 11:00:32 +0530 [thread overview]
Message-ID: <113ACA888B71994BB56E5CF3704953486D6CE1E2DF@BGMAIL02.nvidia.com> (raw)
In-Reply-To: <1402028592.3038.4.camel@joe-AO725>
oops... I missed it somehow. I'll post a new patch.
> -----Original Message-----
> From: Joe Perches [mailto:joe@perches.com]
> Sent: Friday, June 06, 2014 9:53 AM
> To: Vidya Sagar
> Cc: linux@arm.linux.org.uk; bhelgaas@google.com;
> wangyijing@huawei.com; thierry.reding@gmail.com;
> jason@lakedaemon.net; will.deacon@arm.com; Stephen Warren; Krishna
> Thota; sagar.tv@gmail.com; linux-arm-kernel@lists.infradead.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v2] ARM: fix debug prints relevant to PCI devices
>
> On Fri, 2014-06-06 at 00:17 +0530, Vidya Sagar wrote:
> > * replaced printk with pr_info
> []
> > diff --git a/arch/arm/kernel/bios32.c b/arch/arm/kernel/bios32.c
> []
> > @@ -354,9 +357,11 @@ void pcibios_fixup_bus(struct pci_bus *bus)
> >
> > /*
> > * Report what we did for this bus
> > + * (only if the bus doesn't have even one PCIe device)
> > */
> > - printk(KERN_INFO "PCI: bus%d: Fast back to back transfers
> %sabled\n",
> > - bus->number, (features & PCI_COMMAND_FAST_BACK) ?
> "en" : "dis");
> > + if (!has_pcie_dev)
> > + pr_info(KERN_INFO "PCI: bus%d: Fast back to back transfers
> %sabled\n",
> > + bus->number, (features &
> PCI_COMMAND_FAST_BACK) ? "en" : "dis");
>
> when you convert to pr_<level> you need to remove the KERN_<LEVEL>
> from the format string too.
>
prev parent reply other threads:[~2014-06-06 5:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-05 18:47 Vidya Sagar
2014-06-06 4:23 ` Joe Perches
2014-06-06 5:30 ` Vidya Sagar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=113ACA888B71994BB56E5CF3704953486D6CE1E2DF@BGMAIL02.nvidia.com \
--to=vidyas@nvidia.com \
--cc=bhelgaas@google.com \
--cc=jason@lakedaemon.net \
--cc=joe@perches.com \
--cc=kthota@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=sagar.tv@gmail.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=wangyijing@huawei.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®