From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75D6CC2D0E4 for ; Fri, 27 Nov 2020 12:45:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 20FBE22248 for ; Fri, 27 Nov 2020 12:45:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729148AbgK0Mpb (ORCPT ); Fri, 27 Nov 2020 07:45:31 -0500 Received: from frasgout.his.huawei.com ([185.176.79.56]:2169 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726477AbgK0Mpa (ORCPT ); Fri, 27 Nov 2020 07:45:30 -0500 Received: from fraeml712-chm.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4CjDnn17sQz67JnM; Fri, 27 Nov 2020 20:43:41 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml712-chm.china.huawei.com (10.206.15.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 27 Nov 2020 13:45:29 +0100 Received: from [10.210.170.35] (10.210.170.35) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1913.5; Fri, 27 Nov 2020 12:45:27 +0000 Subject: Re: [PATCH v2 1/3] genirq/affinity: Add irq_update_affinity_desc() To: Marc Zyngier CC: Thomas Gleixner , , , , , , , References: <87ft57r7v3.fsf@nanos.tec.linutronix.de> <78356caa-57a0-b807-fe52-8f12d36c1789@huawei.com> <874klmqu2r.fsf@nanos.tec.linutronix.de> <87lfexp6am.fsf@nanos.tec.linutronix.de> <3acb7fde-eae2-a223-9cfd-f409cc2abba6@huawei.com> <873615oy8a.fsf@nanos.tec.linutronix.de> <4aab9d3b-6ca6-01c5-f840-459f945c7577@huawei.com> <87sg91ik9e.wl-maz@kernel.org> <0edc9a11-0b92-537f-1790-6b4b6de4900d@huawei.com> <5a314713-c1ee-2d34-bee1-60beae274742@huawei.com> <0525a4bcf17a355cd141632d4f3714be@kernel.org> <702e1729-9a4b-b16f-6a58-33172b1a3220@huawei.com> <5a588f5d86010602ff9a90e8f057743c@kernel.org> <80e0a19b-3291-1304-1a5b-0445c49efe31@huawei.com> <696c04a9-8c13-0fec-08c4-068d4dd5ba67@huawei.com> <34953f2d7b61f37ab1333627dc256975@kernel.org> From: John Garry Message-ID: <113d72e1-a624-5da9-89cf-eee950e5c984@huawei.com> Date: Fri, 27 Nov 2020 12:45:05 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: <34953f2d7b61f37ab1333627dc256975@kernel.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.210.170.35] X-ClientProxiedBy: lhreml706-chm.china.huawei.com (10.201.108.55) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/11/2020 09:57, Marc Zyngier wrote: >> If I understand the code correctly, MSI_ALLOC_FLAGS_SHARED_DEVICE is >> supposed to be set in info->flags in platform_msi_set_desc(), but this >> is called per-msi after its_msi_prepare(), so we don't the flags set >> at the right time. That's how it looks to me... > > Meh. I was trying multiple things, and of course commited the worse > possible approach. > > I've updated the branch, having verified that we do get the flag in > the ITS now. Hi Marc, That looks to work. So do you have an upstream plan for this? I ask, as if you go with this, then I may change my series to map and unmap all the irqs again - but not sure about that. Thanks, John