From: "Javier González" <jg@lightnvm.io>
To: Rakesh Pandit <rakesh@tuxera.com>
Cc: "Matias Bjørling" <mb@lightnvm.io>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] lightnvm: pblk: remove useless line
Date: Mon, 2 Oct 2017 13:29:30 +0200 [thread overview]
Message-ID: <1140487A-C473-4A23-BCAC-465C2CCC852D@lightnvm.io> (raw)
In-Reply-To: <20171001132302.GA5668@hercules.tuxera.com>
[-- Attachment #1: Type: text/plain, Size: 881 bytes --]
> On 1 Oct 2017, at 15.23, Rakesh Pandit <rakesh@tuxera.com> wrote:
>
> Signed-off-by: Rakesh Pandit <rakesh@tuxera.com>
> ---
> drivers/lightnvm/pblk-core.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 1f8aa94..4ffd1d6 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -1053,7 +1053,6 @@ static int pblk_line_init_bb(struct pblk *pblk, struct pblk_line *line,
> /* Mark emeta metadata sectors as bad sectors. We need to consider bad
> * blocks to make sure that there are enough sectors to store emeta
> */
> - bit = lm->sec_per_line;
> off = lm->sec_per_line - lm->emeta_sec[0];
> bitmap_set(line->invalid_bitmap, off, lm->emeta_sec[0]);
> while (nr_bb) {
> --
> 2.7.4
LGTM
Reviewed-by: Javier González <javier@cnexlabs.com>
[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-10-02 11:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-01 13:23 Rakesh Pandit
2017-10-02 11:29 ` Javier González [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140487A-C473-4A23-BCAC-465C2CCC852D@lightnvm.io \
--to=jg@lightnvm.io \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mb@lightnvm.io \
--cc=rakesh@tuxera.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®