From: "Bryan O'Sullivan" <bos@pathscale.com>
To: Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@suse.de>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH] Define wc_wmb, a write barrier for PCI write combining
Date: Fri, 24 Feb 2006 20:20:50 -0800 [thread overview]
Message-ID: <1140841250.2587.33.camel@localhost.localdomain> (raw)
On some platforms, a regular wmb() is not sufficient to guarantee that
PCI writes have been flushed to the bus if write combining is in effect.
This change introduces a new macro, wc_wmb(), that makes this guarantee.
It does so by way of a new header file, <linux/system.h>. This header
can be a site for oft-replicated code from <asm-*/system.h>, but isn't
just yet.
We also define a version of wc_wmb() with the required semantics
on x86_64.
Signed-off-by: Bryan O'Sullivan <bos@pathscale.com>
diff -r c89918da5f7b -r 94d372e00ccd include/asm-x86_64/system.h
--- a/include/asm-x86_64/system.h Sat Feb 25 08:01:07 2006 +0800
+++ b/include/asm-x86_64/system.h Fri Feb 24 20:15:07 2006 -0800
@@ -321,6 +321,8 @@ static inline unsigned long __cmpxchg(vo
#define mb() asm volatile("mfence":::"memory")
#define rmb() asm volatile("lfence":::"memory")
+#define wc_wmb() asm volatile("sfence" ::: "memory")
+
#ifdef CONFIG_UNORDERED_IO
#define wmb() asm volatile("sfence" ::: "memory")
#else
diff -r c89918da5f7b -r 94d372e00ccd include/linux/system.h
--- /dev/null Thu Jan 1 00:00:00 1970 +0000
+++ b/include/linux/system.h Fri Feb 24 20:15:07 2006 -0800
@@ -0,0 +1,27 @@
+/*
+ * Copyright 2006 PathScale, Inc. All Rights Reserved.
+ *
+ * This file is free software; you can redistribute it and/or modify
+ * it under the terms of version 2 of the GNU General Public License
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software Foundation,
+ * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA.
+ */
+
+#ifndef _LINUX_SYSTEM_H
+#define _LINUX_SYSTEM_H
+
+#include <asm/system.h>
+
+#ifndef wc_wmb
+#define wc_wmb() wmb()
+#endif
+
+#endif /* _LINUX_SYSTEM_H */
next reply other threads:[~2006-02-25 4:20 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-25 4:20 Bryan O'Sullivan [this message]
2006-02-25 4:43 ` Andi Kleen
2006-02-25 7:34 ` Bryan O'Sullivan
2006-02-25 13:28 ` Andi Kleen
2006-02-25 17:20 ` Bryan O'Sullivan
2006-02-25 19:01 ` Bryan O'Sullivan
2006-02-28 17:44 ` Jesse Barnes
2006-02-28 17:50 ` Roland Dreier
2006-02-28 17:50 ` Jesse Barnes
2006-02-28 17:52 ` Bryan O'Sullivan
2006-02-28 17:59 ` Jesse Barnes
2006-02-25 14:28 ` Benjamin LaHaise
2006-02-25 17:11 ` Bryan O'Sullivan
2006-02-25 17:41 ` Benjamin LaHaise
2006-02-28 17:50 ` Bryan O'Sullivan
2006-02-28 17:58 ` Benjamin LaHaise
2006-02-28 18:20 ` Bryan O'Sullivan
2006-02-28 19:03 ` Benjamin LaHaise
2006-02-28 19:20 ` Bryan O'Sullivan
2006-02-28 19:33 ` Andi Kleen
2006-02-28 19:44 ` Bryan O'Sullivan
2006-03-01 19:20 ` Bryan O'Sullivan
2006-03-01 19:27 ` Andi Kleen
2006-03-01 19:43 ` Bryan O'Sullivan
2006-03-01 19:49 ` Andi Kleen
2006-03-01 20:05 ` Bryan O'Sullivan
2006-03-01 20:26 ` Benjamin LaHaise
2006-03-01 20:35 ` Bryan O'Sullivan
2006-02-28 19:34 ` Benjamin LaHaise
2006-02-28 18:22 ` Christopher Friesen
2006-02-28 10:01 ` Jes Sorensen
2006-02-28 15:42 ` Roland Dreier
2006-02-28 16:08 ` Jes Sorensen
2006-02-28 17:02 ` Roland Dreier
2006-02-28 17:13 ` Jesse Barnes
2006-02-28 17:20 ` Jes Sorensen
2006-03-01 8:16 ` Jeremy Higdon
2006-03-01 8:24 ` Jeremy Higdon
2006-02-28 17:11 ` Jesse Barnes
2006-02-28 17:57 ` Bryan O'Sullivan
2006-02-28 18:07 ` linux-os (Dick Johnson)
2006-02-28 18:24 ` Christopher Friesen
2006-03-01 10:45 ` Jes Sorensen
2006-03-01 17:04 ` Roland Dreier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1140841250.2587.33.camel@localhost.localdomain \
--to=bos@pathscale.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome