From: James Bottomley <James.Bottomley@SteelEye.com>
To: Mike Christie <michaelc@cs.wisc.edu>
Cc: dougg@torque.net, Linus Torvalds <torvalds@osdl.org>,
Matthias Andree <matthias.andree@gmx.de>,
Mark Rustad <mrustad@mac.com>,
linux-scsi@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: sg regression in 2.6.16-rc5
Date: Wed, 01 Mar 2006 16:30:35 -0600 [thread overview]
Message-ID: <1141252235.3276.63.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <1141245769.9586.6.camel@max>
On Wed, 2006-03-01 at 14:42 -0600, Mike Christie wrote:
> The current sg driver should use alloc_pages() with an order that should
> get 32 KB. If the order being passed to alloc_pages() in sg.c is only
> getting one page by default that is bug.
> The generic routines now being used can turn that 32KB segment into
> multiple 4KB ones if the LLD does not support clustering.
To be honest, the original behaviour was a bug. A device that doesn't
enable clustering is telling us it can't take anything other than
PAGE_SIZE chunks ... trying to give it more is likely to end in tears.
However ... I'm not sure we actually have any devices that anyone can
identify which truly can't enable clustering (a lot which have it
disabled, I suspect, are that way historically because their writers
didn't trust the clustering algorithm).
So ... I think we can go ahead and cautiously enable clustering (as a
separate patch like Jens suggested).
James
next prev parent reply other threads:[~2006-03-01 22:31 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-28 17:54 Mark Rustad
2006-02-28 19:53 ` Douglas Gilbert
2006-02-28 20:38 ` Kai Makisara
2006-03-01 2:04 ` Douglas Gilbert
2006-03-01 2:08 ` Mark Rustad
2006-03-01 8:38 ` Matthias Andree
2006-03-01 18:28 ` Linus Torvalds
2006-03-01 18:32 ` Mark Lord
2006-03-01 18:42 ` Linus Torvalds
2006-03-01 18:50 ` Matthew Wilcox
2006-03-03 18:27 ` Steve Byan
2006-03-03 18:55 ` Linus Torvalds
2006-03-03 19:13 ` Steve Byan
2006-03-03 19:42 ` Jeff Garzik
2006-03-03 20:09 ` Linus Torvalds
2006-03-03 20:30 ` Jeff Garzik
2006-03-01 19:33 ` Douglas Gilbert
2006-03-01 20:42 ` Mike Christie
2006-03-01 22:30 ` James Bottomley [this message]
2006-03-01 22:56 ` Mike Christie
2006-03-01 21:06 ` Kai Makisara
2006-03-02 19:50 ` Douglas Gilbert
2006-03-02 21:25 ` Linus Torvalds
2006-03-02 23:04 Falkinder, David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141252235.3276.63.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=dougg@torque.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=matthias.andree@gmx.de \
--cc=michaelc@cs.wisc.edu \
--cc=mrustad@mac.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®