From: Jiri Slaby <jirislaby@gmail.com>
To: Andrew Morton <akpm@osdl.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH 3/3] Char: mxser_new, remove useless spinlock
Date: Fri, 22 Dec 2006 23:51:10 +0100 (CET) [thread overview]
Message-ID: <1141328742697215348@wsc.cz> (raw)
In-Reply-To: <2548619677109123490@wsc.cz>
mxser_new, remove useless spinlock
gm_lock is useless, since ISA is configured at init time and there it's
serialized.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
---
commit 5f93193574c932263132e3262853be671e9d1642
tree 94693e221836fd7234e290b9911757357889a580
parent 04a4dbf03a9fdc4c53282ab7e1db146389140c3b
author Jiri Slaby <jirislaby@gmail.com> Fri, 22 Dec 2006 23:04:17 +0059
committer Jiri Slaby <jirislaby@gmail.com> Fri, 22 Dec 2006 23:04:17 +0059
drivers/char/mxser_new.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/char/mxser_new.c b/drivers/char/mxser_new.c
index 2f173e9..103f0b5 100644
--- a/drivers/char/mxser_new.c
+++ b/drivers/char/mxser_new.c
@@ -313,7 +313,6 @@ static int mxvar_diagflag;
static unsigned char mxser_msr[MXSER_PORTS + 1];
static struct mxser_mon_ext mon_data_ext;
static int mxser_set_baud_method[MXSER_PORTS + 1];
-static spinlock_t gm_lock;
#ifdef CONFIG_PCI
static int __devinit CheckIsMoxaMust(int io)
@@ -1377,7 +1376,6 @@ static int __init mxser_program_mode(int port)
{
int id, i, j, n;
- spin_lock(&gm_lock);
outb(0, port);
outb(0, port);
outb(0, port);
@@ -1385,7 +1383,6 @@ static int __init mxser_program_mode(int port)
(void)inb(port);
outb(0, port);
(void)inb(port);
- spin_unlock(&gm_lock);
id = inb(port + 1) & 0x1F;
if ((id != C168_ASIC_ID) &&
@@ -2684,7 +2681,6 @@ static int __init mxser_module_init(void)
mxvar_sdriver = alloc_tty_driver(MXSER_PORTS + 1);
if (!mxvar_sdriver)
return -ENOMEM;
- spin_lock_init(&gm_lock);
printk(KERN_INFO "MOXA Smartio/Industio family driver version %s\n",
MXSER_VERSION);
prev parent reply other threads:[~2006-12-22 22:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-22 22:50 [PATCH 1/3] Char: mxser, fix oops when removing opened Jiri Slaby
2006-12-22 22:51 ` [PATCH 2/3] Char: mxser_new, mark init functions Jiri Slaby
2006-12-22 22:51 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141328742697215348@wsc.cz \
--to=jirislaby@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®