From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [Patch] Dead code in drivers/isdn/avm/avmcard.h
Date: Tue, 07 Mar 2006 21:38:02 +0100 [thread overview]
Message-ID: <1141763882.8321.4.camel@alice> (raw)
In-Reply-To: <20060307203059.GB705@ds20.borg.net>
On Tue, 2006-03-07 at 20:30 +0000, Thorsten Kranzkowski wrote:
> On Tue, Mar 07, 2006 at 08:48:20PM +0100, Eric Sesterhenn wrote:
> > hi,
> >
> > this fixes coverity id #2. the if (i==0) is pretty useless,
> > since we assing i=0, just the line before.
> > Just compile tested.
>
> Iff this is the right fix the comment should be removed as well, no?
updated patch below.
Signed-off-by: Eric Sesterhenn
--- linux-2.6.16-rc5-mm1/drivers/isdn/hardware/avm/avmcard.h.orig 2006-03-07 20:44:33.000000000 +0100
+++ linux-2.6.16-rc5-mm1/drivers/isdn/hardware/avm/avmcard.h 2006-03-07 21:34:31.000000000 +0100
@@ -437,9 +437,7 @@ static inline unsigned int t1_get_slice(
#endif
dp += i;
i = 0;
- if (i == 0)
- break;
- /* fall through */
+ break;
default:
*dp++ = b1_get_byte(base);
i--;
next prev parent reply other threads:[~2006-03-07 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-07 19:48 Eric Sesterhenn
[not found] ` <20060307203059.GB705@ds20.borg.net>
2006-03-07 20:38 ` Eric Sesterhenn [this message]
2006-03-07 21:17 ` Olaf Titz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141763882.8321.4.camel@alice \
--to=snakebyte@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome