From: Arjan van de Ven <arjan@infradead.org>
To: Kirill Korotaev <dev@openvz.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Al Viro <viro@ftp.linux.org.uk>,
devel@openvz.org, Andrey Savochkin <saw@saw.sw.com.sg>
Subject: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside (ver. 3)
Date: Fri, 10 Mar 2006 09:46:25 +0100 [thread overview]
Message-ID: <1141980385.2876.30.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <44113CCC.5080602@openvz.org>
On Fri, 2006-03-10 at 11:46 +0300, Kirill Korotaev wrote:
> Andrew,
>
> Fixed both comments from Al Viro (thanks, Al):
> - should have a separate helper
> - should pass 0 instead of GFP_KERNEL in page_symlink()
>
> + page = find_or_create_page(mapping, 0,
> + mapping_gfp_mask(mapping) | gfp_mask);
this does not work; GFP_NOFS has a bit *LESS* than GFP_KERNEL, not a bit
more. As such a | operation isn't going to be useful....
(So I think that while Al's intention was good, the implication of it
isn't ;)
next prev parent reply other threads:[~2006-03-10 8:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 8:46 Kirill Korotaev
2006-03-10 8:46 ` Arjan van de Ven [this message]
2006-03-10 8:56 ` Andrew Morton
2006-03-10 9:11 ` Kirill Korotaev
2006-03-10 8:57 ` Kirill Korotaev
2006-03-10 8:59 ` Al Viro
2006-03-10 9:40 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1141980385.2876.30.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=dev@openvz.org \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=saw@saw.sw.com.sg \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®