From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: Aurelien Degremont <aurelien.degremont@cea.fr>
Cc: Jacques-Charles Lafoucriere <jc.lafoucriere@cea.fr>,
Bruno Faccini <bruno.faccini@bull.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix deadlock in RPC scheduling code.
Date: Mon, 13 Mar 2006 11:08:23 -0500 [thread overview]
Message-ID: <1142266103.8017.1.camel@lade.trondhjem.org> (raw)
In-Reply-To: <200603131516.QAA19564@styx.bruyeres.cea.fr>
On Mon, 2006-03-13 at 16:16 +0100, Aurelien Degremont wrote:
> IMO, the code will still hang because, the list_for_each_entry_safe()
> loop will never complete, even with the new scheme. Indeed, the loop
> call __rpc_wake_up_task() will try to set RPC_TASK_WAKEUP bit, but it is
> already set by rpc_wake_up_task(), so it hangs...
Look again. There is nothing that loops in __rpc_wake_up_task(). If the
RPC_TASK_WAKEUP is already set, then the function exits.
Cheers,
Trond
prev parent reply other threads:[~2006-03-13 16:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-09 10:35 Aurelien Degremont
2006-03-09 14:40 ` Trond Myklebust
2006-03-10 15:10 ` Aurelien Degremont
2006-03-10 15:24 ` Trond Myklebust
2006-03-13 10:07 ` Aurelien Degremont
2006-03-13 14:28 ` Trond Myklebust
2006-03-13 15:16 ` Aurelien Degremont
2006-03-13 16:08 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142266103.8017.1.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=aurelien.degremont@cea.fr \
--cc=bruno.faccini@bull.net \
--cc=jc.lafoucriere@cea.fr \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®