From: Arjan van de Ven <arjan@infradead.org>
To: prasanna@in.ibm.com
Cc: Andrew Morton <akpm@osdl.org>,
ak@suse.de, davem@davemloft.net, suparna@in.ibm.com,
richardj_moore@uk.ibm.com, linux-kernel@vger.kernel.org
Subject: Re: [3/3 PATCH] Kprobes: User space probes support- single stepping out-of-line
Date: Mon, 20 Mar 2006 15:13:48 +0100 [thread overview]
Message-ID: <1142864028.3114.51.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060320140503.GB18975@in.ibm.com>
On Mon, 2006-03-20 at 19:35 +0530, Prasanna S Panchamukhi wrote:
> On Mon, Mar 20, 2006 at 12:24:01PM +0100, Arjan van de Ven wrote:
> >
> > Lines: 16
> >
> > > And we'll need to actually *be* in-atomic. That means we need an
> > > open-coded inc_preempt_count() and dec_preempt_count() in there and I don't
> > > see them.
> > >
> >
> > ..
> >
> > > Why is VM_LOCKED being set? (It needs a comment).
> > >
> > > Where does it get unset?
> >
> >
> > if this is an attempt to make the copy_in_atomic to be atomic, then it
> > is a bug; the user can unset this bit after all via mprotect, even from
> > another thread, and concurrently. U
>
> You are right, the purpose was to make copy_to_user_inatomic() to suceed. I
> need to look at this issue again. Any suggestions?
get_user_pages seems to be the only viable API for this..
next prev parent reply other threads:[~2006-03-20 14:14 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-20 6:07 [0/3] Kprobes: User space probes support Prasanna S Panchamukhi
2006-03-20 6:09 ` [1/3 PATCH] Kprobes: User space probes support- base interface Prasanna S Panchamukhi
2006-03-20 6:10 ` [2/3 PATCH] Kprobes: User space probes support- readpage hooks Prasanna S Panchamukhi
2006-03-20 6:11 ` [3/3 PATCH] Kprobes: User space probes support- single stepping out-of-line Prasanna S Panchamukhi
2006-03-20 11:09 ` Andrew Morton
2006-03-20 11:24 ` Arjan van de Ven
2006-03-20 14:05 ` Prasanna S Panchamukhi
2006-03-20 14:13 ` Arjan van de Ven [this message]
2006-03-20 11:32 ` Nick Piggin
2006-03-20 13:52 ` Prasanna S Panchamukhi
2006-03-20 13:48 ` Prasanna S Panchamukhi
2006-03-20 20:40 ` Andrew Morton
2006-03-21 2:02 ` Prasanna S Panchamukhi
2006-03-21 10:05 ` Andrew Morton
2006-03-21 11:05 ` Richard J Moore
2006-03-21 11:13 ` Suparna Bhattacharya
2006-03-21 12:23 ` Prasanna S Panchamukhi
2006-03-20 10:53 ` [2/3 PATCH] Kprobes: User space probes support- readpage hooks Andrew Morton
2006-03-20 13:48 ` Prasanna S Panchamukhi
2006-03-21 2:12 ` Andrew Morton
2006-03-21 9:14 ` Richard J Moore
2006-03-21 11:14 ` Christoph Hellwig
2006-03-21 11:38 ` Richard J Moore
2006-03-21 12:40 ` Theodore Ts'o
2006-03-21 11:28 ` Christoph Hellwig
2006-03-21 11:42 ` Richard J Moore
2006-03-21 12:15 ` Christoph Hellwig
2006-03-21 16:17 ` Richard J Moore
2006-03-20 11:10 ` Andrew Morton
2006-03-20 13:59 ` Prasanna S Panchamukhi
2006-03-20 10:42 ` [1/3 PATCH] Kprobes: User space probes support- base interface Andrew Morton
2006-03-20 13:48 ` Prasanna S Panchamukhi
2006-03-21 11:39 ` [0/3] Kprobes: User space probes support Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142864028.3114.51.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=richardj_moore@uk.ibm.com \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®