From: James Bottomley <James.Bottomley@SteelEye.com>
To: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH 2/2] add flush_kernel_dcache_page() API
Date: Tue, 21 Mar 2006 13:45:41 -0600 [thread overview]
Message-ID: <1142970341.3428.15.camel@mulgrave.il.steeleye.com> (raw)
We have a problem in a lot of emulated storage in that it takes a page
from get_user_pages() and does something like
kmap_atomic(page)
modify page
kunmap_atomic(page)
However, nothing has flushed the kernel cache view of the page before
the kunmap. We need a lightweight API to do this, so this new API
would specifically be for flushing the kernel cache view of a user
page which the kernel has modified. The driver would need to add
flush_kernel_dcache_page(page) before the final kunmap.
Signed-off-by: James Bottomley <James.Bottomley@SteelEye.com>
Index: BUILD-2.6/Documentation/cachetlb.txt
===================================================================
--- BUILD-2.6.orig/Documentation/cachetlb.txt 2006-03-21 13:37:45.000000000 -0600
+++ BUILD-2.6/Documentation/cachetlb.txt 2006-03-21 13:37:54.000000000 -0600
@@ -371,6 +371,18 @@
architectures). For incoherent architectures, it should flush
the cache of the page at vmaddr in the current user process.
+ void flush_kernel_dcache_page(struct page *page)
+ When the kernel needs to modify a user page is has obtained
+ with kmap, it calls this function after all modifications are
+ complete (but before kunmapping it) to bring the underlying
+ page up to date. It is assumed here that the user has no
+ incoherent cached copies (i.e. the original page was obtained
+ from a mechanism like get_user_pages()). The default
+ implementation is a nop and should remain so on all coherent
+ architectures. On incoherent architectures, this should flush
+ the kernel cache for page (using page_address(page)).
+
+
void flush_icache_range(unsigned long start, unsigned long end)
When the kernel stores into addresses that it will execute
out of (eg when loading modules), this function is called.
Index: BUILD-2.6/include/linux/highmem.h
===================================================================
--- BUILD-2.6.orig/include/linux/highmem.h 2006-03-21 13:37:19.000000000 -0600
+++ BUILD-2.6/include/linux/highmem.h 2006-03-21 13:37:54.000000000 -0600
@@ -13,6 +13,12 @@
}
#endif
+#ifndef ARCH_HAS_FLUSH_KERNEL_DCACHE_PAGE
+static inline void flush_kernel_dcache_page(struct page *page)
+{
+}
+#endif
+
#ifdef CONFIG_HIGHMEM
#include <asm/highmem.h>
reply other threads:[~2006-03-21 19:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1142970341.3428.15.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®