From: Arjan van de Ven <arjan@infradead.org>
To: minyard@acm.org
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Yani Ioannou <yani.ioannou@gmail.com>,
greg@kroah.com, dtor_core@ameritech.net,
rmk+lkml@arm.linux.org.uk
Subject: Re: [PATCH] Try 3, Fix release function in IPMI device model
Date: Thu, 23 Mar 2006 09:02:01 +0100 [thread overview]
Message-ID: <1143100922.3147.3.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060322231947.GA22494@i2.minyard.local>
On Wed, 2006-03-22 at 17:19 -0600, Corey Minyard wrote:
> I didn't get any comments on this, so I assume it is correct.
> I fixed the spelling of Arjan's name (profuse apologies) in
> this version, but otherwise it is the same.
>
> I'm sorry to cause so much trouble with this.
>
> -Corey
>
>
>
> Arjan van de Ven pointed out that the changeover to the driver model
> in the IPMI driver had some bugs in it dealing with the release
> function and cleanup. Then Russell King pointed out that you can't
> put release functions in the same module as the unregistering code.
>
> This patch fixes those problems and also adds a semaphore around the
> BMC functions and converts the BMC counter to a kref, which I meant to
> do earlier, but didn't write down :(.
please use a mutex not a semaphore... semaphores for mutex code are
deprecated
prev parent reply other threads:[~2006-03-23 8:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-22 23:19 Corey Minyard
2006-03-23 8:02 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143100922.3147.3.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=yani.ioannou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®