From: Thomas Gleixner <tglx@linutronix.de>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: [patch-mm2] PI-futex: fix timeout race
Date: Tue, 28 Mar 2006 12:17:28 +0200 [thread overview]
Message-ID: <1143541048.5344.182.camel@localhost.localdomain> (raw)
In-Reply-To: <20060326231638.GA18395@elte.hu>
The futex code has consequently the same timeout race as generic sleeper
based nanosleep. Call hrtimer_cancel() unconditionally.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Index: linux-2.6.16-mm2/kernel/rtmutex.c
===================================================================
--- linux-2.6.16-mm2.orig/kernel/rtmutex.c
+++ linux-2.6.16-mm2/kernel/rtmutex.c
@@ -789,7 +789,7 @@ rt_mutex_slowlock(struct rt_mutex *lock,
spin_unlock_irqrestore(&lock->wait_lock, flags);
/* Remove pending timer: */
- if (unlikely(timeout && timeout->task))
+ if (unlikely(timeout))
hrtimer_cancel(&timeout->timer);
/*
next prev parent reply other threads:[~2006-03-28 10:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-25 18:46 [patch 05/10] PI-futex: rt-mutex core Ingo Molnar
2006-03-26 5:35 ` Andrew Morton
2006-03-26 23:33 ` Ingo Molnar
2006-03-26 6:07 ` Andrew Morton
2006-03-26 16:03 ` [patch] PI-futex: -V2 Ingo Molnar
2006-03-26 19:16 ` Andrew Morton
2006-03-26 23:30 ` Ingo Molnar
2006-03-26 23:16 ` [patch] PI-futex: -V3 Ingo Molnar
2006-03-28 10:17 ` Thomas Gleixner [this message]
2006-03-31 19:14 ` [patch] PI-futex patchset: -V4 Ingo Molnar
2006-03-31 19:23 ` Ingo Molnar
2006-04-01 0:19 ` Peter Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1143541048.5344.182.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome