mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: Eric Dumazet <dada1@cosmosbay.com>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, mingo@elte.hu, roe@sgi.com,
	steiner@sgi.com, clameter@sgi.com
Subject: Re: [PATCH] Call get_time() only when necessary in run_hrtimer_queue
Date: Tue, 28 Mar 2006 21:20:39 +0200	[thread overview]
Message-ID: <1143573640.5344.215.camel@localhost.localdomain> (raw)
In-Reply-To: <20060328175511.GC13918@sgi.com>

On Tue, 2006-03-28 at 11:55 -0600, Dimitri Sivanich wrote:
> We could the following simpler change instead:
> 
> Signed-off-by: Dimitri Sivanich <sivanich@sgi.com>
> 
> Index: linux/kernel/hrtimer.c
> ===================================================================
> --- linux.orig/kernel/hrtimer.c	2006-03-28 11:46:45.279722496 -0600
> +++ linux/kernel/hrtimer.c	2006-03-28 11:51:36.722469752 -0600
> @@ -606,6 +606,9 @@ static inline void run_hrtimer_queue(str
>  {
>  	struct rb_node *node;
>  
> +	if (!base->first)
> +		return;
> +
>  	if (base->get_softirq_time)
>  		base->softirq_time = base->get_softirq_time();
>  

Looks much better. Can you please resubmit with a proper patch
description ?

Please add: Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

	tglx



  reply	other threads:[~2006-03-28 19:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-24 17:51 Dimitri Sivanich
2006-03-24 22:28 ` Andrew Morton
2006-03-25  7:01   ` Thomas Gleixner
2006-03-28 16:51   ` Dimitri Sivanich
2006-03-28 17:39     ` Eric Dumazet
2006-03-28 17:55       ` Dimitri Sivanich
2006-03-28 19:20         ` Thomas Gleixner [this message]
2006-03-28 20:14           ` [PATCH] Call get_softirq_time() only when necessary in run_hrtimer_queue() Dimitri Sivanich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1143573640.5344.215.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=akpm@osdl.org \
    --cc=clameter@sgi.com \
    --cc=dada1@cosmosbay.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=roe@sgi.com \
    --cc=sivanich@sgi.com \
    --cc=steiner@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome