mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ioremap_cached()
Date: Fri, 31 Mar 2006 13:20:44 +0200	[thread overview]
Message-ID: <1143804045.3053.7.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060330164120.GJ13590@parisc-linux.org>


> 
> It seems clear to me that ioremap() and ioremap_nocache() are the
> wrong way around.  The default needs to be uncached -- and the obvious
> (rare) alternative becomes ioremap_cached().
> 
> So here's a patch for i386 to add ioremap_cached() and make ioremap()
> uncached.  ioremap_nocache() remains as an alias for ioremap() so we
> don't needlessly break old drivers.  Architecture maintainers will need
> to fix up their ports if this patch is accepted.

I'd actually suggest deprecating ioremap() and moving away from it to
make sure all users think of which variant they want. Explicit naming is
always better than "some" unknown behavior (especially for old drivers
that work on multiple kernels... while you allow them to keep compiling,
you change the world under them so I think eventually break them
compiling is actually better than having them limp along broken)


      parent reply	other threads:[~2006-03-31 11:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-30 16:41 Matthew Wilcox
2006-03-30 18:27 ` Andi Kleen
2006-03-30 19:34   ` Matthew Wilcox
2006-03-30 19:50     ` Andi Kleen
2006-03-30 20:14       ` Matthew Wilcox
2006-03-30 20:17         ` Andi Kleen
2006-03-30 20:21           ` Kumar Gala
2006-03-30 20:27             ` Andi Kleen
2006-03-31 11:20 ` Arjan van de Ven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1143804045.3053.7.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®