From: Arjan van de Ven <arjan@infradead.org>
To: tim.c.chen@linux.intel.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Kconfig.debug: Set DEBUG_MUTEX to off by default
Date: Sat, 08 Apr 2006 16:42:27 +0200 [thread overview]
Message-ID: <1144507347.2989.2.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1144429008.25886.17.camel@localhost.localdomain>
On Fri, 2006-04-07 at 09:56 -0700, Tim Chen wrote:
> Hi,
>
> DEBUG_MUTEX flag is on by default in current kernel configuration.
>
> During performance testing, we saw mutex debug functions like
> mutex_debug_check_no_locks_freed (called by kfree()) is expensive as it
> goes through a global list of memory areas with mutex lock and do the
> checking. For benchmarks such as Volanomark and Hackbench, we have seen
> more than 40% drop in performance on some platforms. We suggest to set
> DEBUG_MUTEX off by default. Or at least do that later when we feel that
> the mutex changes in the current code have stabilized.
>
> Tim Chen
>
> Signed-off-by: Tim Chen <tim.c.chen@intel.com>
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -101,7 +101,7 @@ config DEBUG_PREEMPT
>
> config DEBUG_MUTEXES
> bool "Mutex debugging, deadlock detection"
> - default y
> + default n
don't do default n, just remove the line instead ;)
prev parent reply other threads:[~2006-04-08 14:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 16:56 Tim Chen
2006-04-08 14:42 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144507347.2989.2.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.c.chen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®