From: Arjan van de Ven <arjan@infradead.org>
To: Karsten Keil <kkeil@suse.de>
Cc: Adrian Bunk <bunk@stusta.de>,
isdn4linux@listserv.isdn4linux.de, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] drivers/isdn/capi/capiutil.c: unexport capi_message2str
Date: Sun, 09 Apr 2006 17:02:39 +0200 [thread overview]
Message-ID: <1144594959.2989.63.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060409130730.GA27948@pingi.kke.suse.de>
On Sun, 2006-04-09 at 15:07 +0200, Karsten Keil wrote:
> On Fri, Apr 07, 2006 at 11:17:36PM +0200, Adrian Bunk wrote:
> > This patch removes an unused EXPORT_SYMBOL.
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > --- linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c.old 2006-04-07 10:47:30.000000000 +0200
> > +++ linux-2.6.17-rc1-mm1-full/drivers/isdn/capi/capiutil.c 2006-04-07 10:47:37.000000000 +0200
> > @@ -855,5 +855,4 @@
> > EXPORT_SYMBOL(capi_cmsg_header);
> > EXPORT_SYMBOL(capi_cmd2str);
> > EXPORT_SYMBOL(capi_cmsg2str);
> > -EXPORT_SYMBOL(capi_message2str);
> > EXPORT_SYMBOL(capi_info2str);
> >
>
> Yes it is currently unused, but part of the CAPI driver SDK for supporting
> debug messages in capi drivers, so I would tend to let it exported, if here
> are not strong arguments against exporting it.
every export takes space in the binary kernel. There's some 900 of these
unused ones, totalling to about 100Kb of unused bloat.
prev parent reply other threads:[~2006-04-09 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-07 21:17 Adrian Bunk
2006-04-09 13:07 ` Karsten Keil
2006-04-09 15:02 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1144594959.2989.63.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=bunk@stusta.de \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®