From: Steven Rostedt <rostedt@goodmis.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>,
Daniel Walker <dwalker@mvista.com>
Subject: [PATCH -rt] Remove false BUG_ON from rtmutex.c
Date: Tue, 18 Apr 2006 10:13:10 -0400 [thread overview]
Message-ID: <1145369590.17085.99.camel@localhost.localdomain> (raw)
In-Reply-To: <1145324887.17085.35.camel@localhost.localdomain>
Ingo,
Here's a patch to remove the BUG_ON in rtmutex.c. I previously showed
that the condition in that particular BUG_ON can legitimately be the
case.
Once again, if you have processes A, B, C, D, and E holding the
following locks in this scenario:
L1 <=blocks= A
<=owns= L2 <=blocks= B <=owns= L4 <=blocks= D
<=owns= L3 <=blocks= C <=owns= L5 <=blocks= E
Where the priorities of these tasks are
B,C < A < D = E
B and C are less than A and A is less than D and E where D and E are
equal (actually it probably works when D and E are not equal too).
As D and E climb the chain, there's a very slight race condition that
could allow for the condition in the offending BUG_ON to be true.
This patch removes that BUG_ON.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Index: linux-2.6.16-rt16/kernel/rtmutex.c
===================================================================
--- linux-2.6.16-rt16.orig/kernel/rtmutex.c 2006-04-17 14:49:43.000000000 -0400
+++ linux-2.6.16-rt16/kernel/rtmutex.c 2006-04-18 09:57:54.000000000 -0400
@@ -232,10 +232,8 @@ static int rt_mutex_adjust_prio_chain(ta
* When deadlock detection is off then we check, if further
* priority adjustment is necessary.
*/
- if (!detect_deadlock && waiter->list_entry.prio == task->prio) {
- BUG_ON(waiter->pi_list_entry.prio != waiter->list_entry.prio);
+ if (!detect_deadlock && waiter->list_entry.prio == task->prio)
goto out_unlock_pi;
- }
lock = waiter->lock;
if (!spin_trylock(&lock->wait_lock)) {
next prev parent reply other threads:[~2006-04-18 14:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-18 1:48 [RT] bad BUG_ON in rtmutex.c Steven Rostedt
2006-04-18 12:20 ` Daniel Walker
2006-04-18 12:34 ` Steven Rostedt
2006-04-18 13:11 ` Daniel Walker
2006-04-18 13:50 ` Steven Rostedt
2006-04-18 13:55 ` Steven Rostedt
2006-04-18 14:09 ` Daniel Walker
2006-04-18 14:32 ` Steven Rostedt
2006-04-18 14:51 ` Daniel Walker
2006-04-18 13:52 ` Ingo Molnar
2006-04-18 15:06 ` Steven Rostedt
2006-04-18 16:14 ` Daniel Walker
2006-04-18 16:24 ` Steven Rostedt
2006-04-18 14:13 ` Steven Rostedt [this message]
2006-04-18 13:12 ` [PATCH -rt] Remove false BUG_ON from rtmutex.c Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145369590.17085.99.camel@localhost.localdomain \
--to=rostedt@goodmis.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®