From: Pekka Enberg <penberg@cs.helsinki.fi>
To: Al Boldi <a1426z@gawab.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] threads_max: Simple lockout prevention patch
Date: Mon, 24 Apr 2006 17:11:35 +0300 [thread overview]
Message-ID: <1145887895.32427.5.camel@localhost> (raw)
In-Reply-To: <200604241653.49647.a1426z@gawab.com>
On 4/24/06, Al Boldi <a1426z@gawab.com> wrote:
> > > Like so?
> > > if (nr_threads >= max_threads)
> > > if (p->pid != su_pid)
> > > goto bad_fork_cleanup_count;
> >
> > It's better to combine the two if statements into one with &&.
On Mon, 2006-04-24 at 16:53 +0300, Al Boldi wrote:
> I thought of combining them too, but was afraid of some compile optimization
> issues. Remember, this code-path is executed for each and every fork in the
> system, thus it's highly performance sensitive.
There shouldn't be any difference. What compiler optimizations are you
referring to? Did you study the generated object code?
Pekka
next prev parent reply other threads:[~2006-04-24 14:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-14 20:27 Al Boldi
2006-01-30 13:21 ` Al Boldi
2006-04-24 4:56 ` Al Boldi
2006-04-24 5:11 ` Andrew Morton
2006-04-24 11:12 ` Al Boldi
2006-04-24 11:22 ` Pekka Enberg
2006-04-24 13:53 ` Al Boldi
2006-04-24 14:11 ` Pekka Enberg [this message]
2006-04-24 14:46 ` Al Boldi
2006-04-24 16:32 ` Pekka Enberg
2006-04-24 11:24 ` Nick Piggin
2006-04-24 13:37 ` Al Boldi
2006-04-25 7:23 ` Nick Piggin
2006-04-25 10:44 ` Al Boldi
2006-04-28 16:58 ` Al Boldi
2006-04-24 7:10 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145887895.32427.5.camel@localhost \
--to=penberg@cs.helsinki.fi \
--cc=a1426z@gawab.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome