From: Arjan van de Ven <arjan@infradead.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Dave Airlie <airlied@linux.ie>, Andrew Morton <akpm@osdl.org>,
Matthew Reppert <arashi@sacredchao.net>,
linux-kernel@vger.kernel.org,
"Antonino A. Daplas" <adaplas@pol.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: PCI ROM resource allocation issue with 2.6.17-rc2
Date: Mon, 24 Apr 2006 19:16:33 +0200 [thread overview]
Message-ID: <1145898993.3116.50.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0604241002460.3701@g5.osdl.org>
On Mon, 2006-04-24 at 10:07 -0700, Linus Torvalds wrote:
>
> On Mon, 24 Apr 2006, Dave Airlie wrote:
> >
> > however not doing pci_enable_device causes interrupts to not work on the cards
> > in a lot of circumstances..
>
> Well, you could use "pci_enable_device_bars(0)" instead.
>
> That will set up interrupt routing _without_ enabling any BAR's, however,
> that's probably crazy too, since that means that if an interrupt happens,
> you're really really screwed and can't do anything about it. So that's
> probably even more broken than what you do now.
>
> How about delaying the "pci_enable_device()" until when you actually need
> it, ie do it in drm_irq_install() instead?
>
> Of course, I wonder how you could POST the device without having the BAR's
> enabled,
you haven't spent enough time reading the X pci code then ;)
(or rather, you've done the same thing but hey who's counting)
X does all that *itself* based on what X thinks is best.
Yes that's silly and X should be taken out and shot for that.
What's worse, this is the kind of thing that is really hard to work
around in a away that isn't going to make having a fixed X work as
well... you can't not enable it for old X and enable it for not-insane X
at the same time ;)
next prev parent reply other threads:[~2006-04-24 17:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-24 4:02 Matthew Reppert
2006-04-24 5:21 ` Andrew Morton
2006-04-24 5:54 ` Dave Airlie
2006-04-24 17:07 ` Linus Torvalds
2006-04-24 17:16 ` Arjan van de Ven [this message]
2006-04-24 17:28 ` Linus Torvalds
2006-04-26 1:23 ` Dave Airlie
2006-04-26 2:10 ` Jon Smirl
2006-04-24 17:01 ` Linus Torvalds
2006-04-26 3:28 ` Dave Airlie
2006-04-26 3:40 ` Debian Kernel with Squash and UnionFS installed Joshua Perrymon
2006-04-26 5:05 ` PCI ROM resource allocation issue with 2.6.17-rc2 Linus Torvalds
2006-04-26 5:56 ` Dave Airlie
2006-04-24 5:28 ` Matthew Reppert
2006-04-24 19:24 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145898993.3116.50.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=adaplas@pol.net \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=arashi@sacredchao.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®