From: Arjan van de Ven <arjan@infradead.org>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Yu, Luming" <luming.yu@intel.com>, Andrew Morton <akpm@osdl.org>,
"Brown, Len" <len.brown@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] reverse pci config space restore order
Date: Tue, 25 Apr 2006 12:51:01 +0200 [thread overview]
Message-ID: <1145962261.3114.23.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060425104800.GA26109@srcf.ucam.org>
On Tue, 2006-04-25 at 11:48 +0100, Matthew Garrett wrote:
> On Tue, Apr 25, 2006 at 02:50:57PM +0800, Yu, Luming wrote:
>
> > - for (i = 0; i < 16; i++)
> > + for (i = 15; i >= 0 ; i--)
>
> We certainly need to do /something/ here, but I'm not sure this is it.
> Adam Belay has code to limit PCI state restoration to the PCI-specified
> registers, with the idea being that individual drivers fix things up
> properly. While this has the obvious drawback that almost every PCI
> driver in the tree would then need fixing up, it's also probably the
> right thing.
it has a second drawback: it assumes all devices HAVE a driver, which
isn't normally the case...
next prev parent reply other threads:[~2006-04-25 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-25 6:50 Yu, Luming
2006-04-25 10:48 ` Matthew Garrett
2006-04-25 10:51 ` Arjan van de Ven [this message]
2006-04-25 11:01 ` Matthew Garrett
2006-04-25 18:22 Brown, Len
2006-04-25 23:59 ` abelay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1145962261.3114.23.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luming.yu@intel.com \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®