From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23A3EC2BA19 for ; Fri, 3 Apr 2020 12:49:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DCD6920659 for ; Fri, 3 Apr 2020 12:49:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=arista.com header.i=@arista.com header.b="ASnR0E3t" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390862AbgDCMt5 (ORCPT ); Fri, 3 Apr 2020 08:49:57 -0400 Received: from mail-ed1-f67.google.com ([209.85.208.67]:34845 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727989AbgDCMt4 (ORCPT ); Fri, 3 Apr 2020 08:49:56 -0400 Received: by mail-ed1-f67.google.com with SMTP id c7so1399529edl.2 for ; Fri, 03 Apr 2020 05:49:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arista.com; s=googlenew; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qQ4GjlaBNnkqjandRnDKumnjBIkctbwHxWdo0M4wsMI=; b=ASnR0E3twBUn3zFHPgwVLzGRCQDeCNzuma4SqK3MmSzZIdWWrXFg8pCBWD4epfIJ+z 2OUBhBph32xan2QlF1RTOih+bc/LuuXJUQlq0iN2y5fu4d+/dnczuhRU9UUVpsoDdYuZ ydiEvmwy9d48th4OPl+a1yTfrR9RPceRVflsdsZkGlttu3jIYGOzb5T/GwGoBaIFpoNA k0KoH4qQBH7tOQ5AH4Xq8UCixq3wVjW29B7w90J3hbU3+JeFSJQhPhGXhAMsfueibgXa c6wfYcKAP/B9C1KT13N/Uqu/GulrAEMyeVQ/PVEvYV0LxhXv0DoqB1zwusHV3iCHBTiK OItw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qQ4GjlaBNnkqjandRnDKumnjBIkctbwHxWdo0M4wsMI=; b=X2rEx6BkXHCYOU7WKYg+fJszDTpwtow2db6Y0QWqnNNPt0SRx5L4vEd/m6c3md9hF/ vyMbAoNtG72e2WWK9fBR0knzcny1lSTdgEyrnqqBxkklp+EsdOziw9mlOvjKagdVKpve 3/nsGSEJJpqXblnY2EjiKea9w3YdOFhTVwbGHJd5V/CUdQM2axwEOnjLstPDeGIaTSWG K+OMWcbb0zQwWY0rM2jBxD199NbtKOMGfrsOscLSTQCidXFE31S9+aXwRlG5cb3pgcdG 4HbVlCUFkSlxNz0KeMoZrrL+yA3k/GSnmSaCAFzVagSR5Lsp1Hr5lh5NGFDiBOMkfrEs plfg== X-Gm-Message-State: AGi0PuY0n1LV5d6ARlkyR8cVYvRLWfZkiH54y0cAVFH0BifYNZd6kOVn jG07DMoohQWEAwZ5AgB3FmUQ2iJ466g= X-Google-Smtp-Source: APiQypL5gP9d5L/YD06dpE9QuVApfFMy3N0f0Ub7xYKYv6KkNS8Zf7gkd/4JdkznDB02IeowhtMk2Q== X-Received: by 2002:a17:906:7045:: with SMTP id r5mr8266254ejj.29.1585918193015; Fri, 03 Apr 2020 05:49:53 -0700 (PDT) Received: from ?IPv6:2a02:8084:e84:2480:228:f8ff:fe6f:83a8? ([2a02:8084:e84:2480:228:f8ff:fe6f:83a8]) by smtp.gmail.com with ESMTPSA id by25sm1649452ejb.16.2020.04.03.05.49.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 03 Apr 2020 05:49:52 -0700 (PDT) Subject: Re: [PATCH] ns: Fix time_for_children symlink To: Christian Brauner , "Michael Kerrisk (man-pages)" Cc: Andrei Vagin , Adrian Reber , "Eric W. Biederman" , Andrei Vagin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Dmitry Safonov <0x7f454c46@gmail.com>, Thomas Gleixner , Vincenzo Frascino , Andy Lutomirski , Cyrill Gorcunov , Containers , stable References: <20200403123431.tsvj6alagg3ee356@wittgenstein> From: Dmitry Safonov Message-ID: <11460527-7d03-0966-508a-b67dc2bc8459@arista.com> Date: Fri, 3 Apr 2020 13:49:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200403123431.tsvj6alagg3ee356@wittgenstein> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/3/20 1:34 PM, Christian Brauner wrote: > On Fri, Apr 03, 2020 at 02:11:39PM +0200, Michael Kerrisk (man-pages) wrote: >> Dmitry, Andrei, >> >> Looking at the contents of the /proc/PID/ns/time_for_children >> symlink shows an anomaly: >> >> $ ls -l /proc/self/ns/* |awk '{print $9, $10, $11}' >> ... >> /proc/self/ns/pid -> pid:[4026531836] >> /proc/self/ns/pid_for_children -> pid:[4026531836] >> /proc/self/ns/time -> time:[4026531834] >> /proc/self/ns/time_for_children -> time_for_children:[4026531834] >> /proc/self/ns/user -> user:[4026531837] >> ... >> >> The reference for 'time_for_children' should be a 'time' namespace, >> just as the reference for 'pid_for_children' is a 'pid' namespace. >> In other words, I think the above time_for_children link should read: >> >> /proc/self/ns/time_for_children -> time:[4026531834] >> >> If you agree with this patch, then it should be marked for >> stable@vger.kernel.org. >> >> Signed-off-by: Michael Kerrisk > > Yeah, that just seems like an oversight. > > Acked-by: Christian Brauner Thanks, Reviewed-by: Dmitry Safonov Fixes: 769071ac9f20 ("ns: Introduce Time Namespace") +Cc: stable # v5.6 -- Dmitry