From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964838AbWDZPwi (ORCPT ); Wed, 26 Apr 2006 11:52:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964839AbWDZPwi (ORCPT ); Wed, 26 Apr 2006 11:52:38 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:39315 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S964838AbWDZPwh (ORCPT ); Wed, 26 Apr 2006 11:52:37 -0400 Subject: Re: [patch] pciehp: dont call pci_enable_dev From: Arjan van de Ven To: Kristen Accardi Cc: pcihpd-discuss@lists.sourceforge.net, greg@kroah.com, linux-kernel@vger.kernel.org In-Reply-To: <1146002437.6478.43.camel@whizzy> References: <1145919059.6478.29.camel@whizzy> <1145945819.3114.0.camel@laptopd505.fenrus.org> <1146002437.6478.43.camel@whizzy> Content-Type: text/plain Date: Wed, 26 Apr 2006 17:52:27 +0200 Message-Id: <1146066747.7016.17.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2006-04-25 at 15:00 -0700, Kristen Accardi wrote: > On Tue, 2006-04-25 at 08:16 +0200, Arjan van de Ven wrote: > > On Mon, 2006-04-24 at 15:50 -0700, Kristen Accardi wrote: > > > Don't call pci_enable_device from pciehp because the pcie port service driver > > > already does this. > > > > hmmmm shouldn't pci_enable_device on a previously enabled device just > > succeed? Sounds more than logical to me to make it that way at least... > > I can't think of any reason why not. Something like this what you had > in mind perhaps? > > --- the question then becomes if enable/disable should become "counting", eg enable twice disable once leaves enabled at count one....