From: Arjan van de Ven <arjan@infradead.org>
To: Badari Pulavarty <pbadari@gmail.com>
Cc: Adrian Bunk <bunk@stusta.de>, Andrew Morton <akpm@osdl.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [RFC: 2.6 patch] fs/read_write.c: unexport iov_shorten
Date: Thu, 27 Apr 2006 20:59:20 +0200 [thread overview]
Message-ID: <1146164361.2894.41.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <1146163983.8365.28.camel@dyn9047017100.beaverton.ibm.com>
On Thu, 2006-04-27 at 11:52 -0700, Badari Pulavarty wrote:
> On Thu, 2006-04-27 at 20:03 +0200, Adrian Bunk wrote:
> > This patch removes the unused EXPORT_SYMBOL(iov_shorten).
> >
> > Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >
> > ---
> >
> > This patch was already sent on:
> > - 23 Apr 2006
> >
> > --- linux-2.6.17-rc1-mm3-full/fs/read_write.c.old 2006-04-23 15:51:52.000000000 +0200
> > +++ linux-2.6.17-rc1-mm3-full/fs/read_write.c 2006-04-23 15:52:02.000000000 +0200
> > @@ -436,8 +436,6 @@
> > return seg;
> > }
> >
> > -EXPORT_SYMBOL(iov_shorten);
> > -
> > /* A write operation does a read from user space and vice versa */
> > #define vrfy_dir(type) ((type) == READ ? VERIFY_WRITE : VERIFY_READ)
> >
>
> How about this ? Wondering if we need to make this "inline" also (since
> its used only in one place).
no real need; if it's static modern gcc will inline it anyway
next prev parent reply other threads:[~2006-04-27 18:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-27 18:03 Adrian Bunk
2006-04-27 18:36 ` Badari Pulavarty
2006-04-27 18:52 ` Badari Pulavarty
2006-04-27 18:59 ` Arjan van de Ven [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-29 19:21 Adrian Bunk
2006-06-25 23:39 Adrian Bunk
2006-04-23 21:22 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146164361.2894.41.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=pbadari@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®