From: David Woodhouse <dwmw2@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [RFC: 2.6 patch] drivers/char/applicom.c: proper module_{init,exit}
Date: Mon, 01 May 2006 14:58:50 +0100 [thread overview]
Message-ID: <1146491930.2885.101.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <20060501071132.GG3570@stusta.de>
On Mon, 2006-05-01 at 09:11 +0200, Adrian Bunk wrote:
> - converts the driver to use module_{init,exit}
Ack.
> - let the driver print a warning if the old __setup is used
> + printk(KERN_WARNING "applicom= is deprecated\n please use applicom.irq= and applicom.mem=\n");
I wouldn't bother with this -- just change it.
--
dwmw2
next prev parent reply other threads:[~2006-05-01 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-01 7:11 Adrian Bunk
2006-05-01 13:58 ` David Woodhouse [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-04-15 19:49 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146491930.2885.101.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®