From: Arjan van de Ven <arjan@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: tklauser@nuerscht.ch, akpm@osdl.org, linux-scsi@vger.kernel.org
Subject: Re: + drivers-scsi-use-array_size-macro.patch added to -mm tree
Date: Mon, 01 May 2006 19:45:19 +0200 [thread overview]
Message-ID: <1146505519.20760.60.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200605011717.k41HHagU001787@shell0.pdx.osdl.net>
On Mon, 2006-05-01 at 10:15 -0700, akpm@osdl.org wrote:
> diff -puN drivers/scsi/53c700.c~drivers-scsi-use-array_size-macro drivers/scsi/53c700.c
> --- devel/drivers/scsi/53c700.c~drivers-scsi-use-array_size-macro 2006-05-01 10:15:39.000000000 -0700
> +++ devel-akpm/drivers/scsi/53c700.c 2006-05-01 10:15:39.000000000 -0700
> @@ -316,7 +316,7 @@ NCR_700_detect(struct scsi_host_template
> BUG_ON(!dma_is_consistent(pScript) && L1_CACHE_BYTES < dma_get_cache_alignment());
> hostdata->slots = (struct NCR_700_command_slot *)(memory + SLOTS_OFFSET);
> hostdata->dev = dev;
> -
> +
> pSlots = pScript + SLOTS_OFFSET;
>
> /* Fill in the missing routines from the host template */
noise?
> @@ -332,19 +332,18 @@ NCR_700_detect(struct scsi_host_template
> tpnt->slave_destroy = NCR_700_slave_destroy;
> tpnt->change_queue_depth = NCR_700_change_queue_depth;
> tpnt->change_queue_type = NCR_700_change_queue_type;
> -
> +
more noise?
> @@ -385,17 +382,17 @@ NCR_700_detect(struct scsi_host_template
> host->hostdata[0] = (unsigned long)hostdata;
> /* kick the chip */
> NCR_700_writeb(0xff, host, CTEST9_REG);
> - if(hostdata->chip710)
> + if (hostdata->chip710)
while a nice cleanup.. does it fit in this patch?
(many more such things snipped)
next parent reply other threads:[~2006-05-01 17:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200605011717.k41HHagU001787@shell0.pdx.osdl.net>
2006-05-01 17:45 ` Arjan van de Ven [this message]
2006-05-01 20:34 ` Tobias Klauser
2006-05-01 21:16 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146505519.20760.60.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tklauser@nuerscht.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®