mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
	js@linuxtv.org, linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] CodingStyle: add typedefs chapter
Date: Tue, 02 May 2006 19:50:53 +0100	[thread overview]
Message-ID: <1146595853.19101.38.camel@pmac.infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0605021137500.4086@g5.osdl.org>

On Tue, 2006-05-02 at 11:41 -0700, Linus Torvalds wrote:
> The problem with uint32_t is that it's ugly, it used to be unportable, and 
> you can't use it in header files _anyway_.

Unportable? It's at least as portable as u32 is, surely? We probably
wouldn't have used <stdint.h> in the kernel anyway -- we define them
ourselves. 

The header files are completely irrelevant too -- we're talking about
'u32' not '__u32'.

The important thing is your belief that it's ugly, which is what was
documented.

> I really object to this whole thing. The fact is, "u8" and friends _are_ 
> the standard types as far as the kernel is concerned.  Claiming that they 
> aren't is just silly.

When describing the CodingStyle rules "thou shalt not use typedefs" we
do need to list the exceptions, and that includes 'u32' et al.

Yes, those _are_ acceptable in the kernel. That's what the document
_says_. It _doesn't_ say that they're not.

-- 
dwmw2


  reply	other threads:[~2006-05-02 18:51 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-01  0:44 Randy.Dunlap
2006-05-01  7:28 ` Michael Buesch
2006-05-01 15:34   ` Randy.Dunlap
2006-05-01 14:00 ` Jan Engelhardt
2006-05-01 14:19   ` Alexey Dobriyan
2006-05-01 14:46     ` linux-os (Dick Johnson)
2006-05-01 15:01       ` Jiri Slaby
2006-05-01 15:33   ` Artem B. Bityutskiy
2006-05-01 16:58   ` David Woodhouse
2006-05-01 20:20     ` Jan Engelhardt
2006-05-01 20:45       ` Jiri Slaby
2006-05-01 21:01         ` Jan Engelhardt
2006-05-01 21:07           ` David Woodhouse
2006-05-01 21:38             ` Alexey Dobriyan
2006-05-02 10:40               ` Jörn Engel
2006-05-02 13:17             ` Jes Sorensen
2006-05-01 17:06 ` David Woodhouse
2006-05-01 20:48   ` Randy.Dunlap
2006-05-02  0:37   ` Johannes Stezenbach
2006-05-02 13:28     ` David Woodhouse
2006-05-02 14:20       ` Johannes Stezenbach
2006-05-02 14:31         ` David Woodhouse
2006-05-02 17:11           ` Randy.Dunlap
2006-05-02 18:41             ` Linus Torvalds
2006-05-02 18:50               ` David Woodhouse [this message]
2006-05-02 19:07                 ` Linus Torvalds
2006-05-02 19:20                   ` Marcel Siegert
2006-05-02 19:44                     ` Linus Torvalds
2006-05-02 23:22                   ` David Woodhouse
2006-05-03 19:41                     ` Randy.Dunlap
2006-05-03 21:52                       ` David Woodhouse
2006-05-03 22:09                         ` Randy.Dunlap
2006-05-03 22:10                           ` David Woodhouse
2006-05-01 21:23 ` Daniel Barkalow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1146595853.19101.38.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@osdl.org \
    --cc=js@linuxtv.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®