From: Daniel Walker <dwalker@mvista.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH -rt] scheduling while atomic in fs/file.c
Date: Wed, 03 May 2006 13:43:25 -0700 [thread overview]
Message-ID: <1146689006.3363.8.camel@localhost.localdomain> (raw)
In-Reply-To: <20060503204504.GA15965@elte.hu>
On Wed, 2006-05-03 at 22:45 +0200, Ingo Molnar wrote:
> * Daniel Walker <dwalker@mvista.com> wrote:
>
> > - fddef = &get_cpu_var(fdtable_defer_list);
> > + fddef = &__get_cpu_var(fdtable_defer_list);
>
> ok, the bug you found is real - but i dont like the fix: now we will be
> using smp_processor_id() in preemptible code, which will trip up under
> DEBUG_PREEMPT. Since in this particular case any CPU is fine,
> per_cpu(...,raw_smp_processor_id()) ought to do the trick. Mind to
> update the patch?
Sure I can do it, not exactly high priority considering it's never been
observed ..
Daniel
next prev parent reply other threads:[~2006-05-03 20:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-22 15:03 Daniel Walker
2006-05-03 20:45 ` Ingo Molnar
2006-05-03 20:43 ` Daniel Walker [this message]
2006-05-14 15:45 Daniel Walker
2006-05-14 16:44 ` Steven Rostedt
2006-05-14 17:32 ` Daniel Walker
2006-05-15 6:43 ` Steven Rostedt
2006-05-15 7:04 ` Steven Rostedt
2006-05-15 13:37 ` Daniel Walker
2006-05-15 14:03 ` Steven Rostedt
2006-05-15 13:51 ` Daniel Walker
2006-05-15 14:05 ` Steven Rostedt
2006-05-16 16:28 Daniel Walker
2006-05-18 7:55 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1146689006.3363.8.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome