From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD4C13B894E for ; Wed, 18 Mar 2026 13:13:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773839587; cv=none; b=hCDpLsCGoJuBeEa4DjWRPVr3vwnZw+TcuOMfNgPWHRnkWHB8CNS2HIWezIi0awTaNRr4Ou7cG5GByveVA6l+nh79kT1clofdHIT8y4f+b4SFQstXdqWq0maTalZG6tVMfSxVaTmfjG7S6qPx35ERBb4mydO/AF2uHNOnXzd6cPw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773839587; c=relaxed/simple; bh=+L9vOqSjiO9a6O165CuZxAw6NKrb8imiDto6ttLiloo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IoUu4k8Jc04TplVu9Qeqqf1Nxlhq2tK9hGoSUkf7Vyz9sWFNsMsfB1WMsIvRTtBgibtjFUy3GE7Tlpqf5YvS8B2AwI7POCmLArstolc71peDvzhXT2eEhY/29CXjO8mmnSbYkNY2ScsK61WvYsK9ApSO98o+5KAzEIe4ovuoSoE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Jz3XS10m; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=kGdm771G; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Jz3XS10m"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="kGdm771G" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I8n0AY084720 for ; Wed, 18 Mar 2026 13:13:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E59iGtHoJttmNzitX+WU26YIvATCm8nHOcVB6LcRIhs=; b=Jz3XS10mK5iWpAMH IZOP/Ga9BaythitcXHYA3vN0cyT1r2vfujIy5BPUxHtRuFWfr6ffG0l2k4DOLCY1 ZWjTGIrIQd75Kq6VlUln45zEZwsuJ7KDKmOteYAn30JGFOJUVGLaMebWdeBRknmr Dimqnhhht2vownssAYk5s6br/zRCWqURZY8nS6QxRJVMgnwIi6V7liAY4J6oqPc0 /aMD9LIGihe1eNN7qRTJg+PUl+0wVv3+YulN16ZaDlTgFOJWgYKb+X26qPN7W2Od TVmxKbSfbrnA0CiBuG+iwZqaIrjJUJtDks/tjO0Ka5e/vA70eOxM2NT62/d8zYW9 oVATFg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cykqetbtu-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 13:13:05 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2b069bfa817so20422365ad.3 for ; Wed, 18 Mar 2026 06:13:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773839584; x=1774444384; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E59iGtHoJttmNzitX+WU26YIvATCm8nHOcVB6LcRIhs=; b=kGdm771GAL1UMY1qjIKsg3GRCV22r1rAfOLE3r2RthxgTUjbTWQrIB0kE/2DaCXMTs xu2Uhwn3+QkMNL0aDj0GvJnPardbnwOdEfv1hCaD8CIXx6KHrHInE4ynsm47hPv4kICp fXle0+Klzp0T8TuL4gzh55TUmYh2oPEaFlgCsbXOeddb6mtVtUzeBZQlFenpbA9goJuc uXIv2hFbR1hBXc88JeXIcO+GoF1B7ZfieWIjr+IxqveXRtugvYNbggr372n5nGsTNtj1 E2t/fJkcAEn4CGkxiFnTFjpqsIdPZGB0LLfM7z26e4rLcFhAPv2VW3GodSqvh7mtjcL1 xZZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773839584; x=1774444384; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E59iGtHoJttmNzitX+WU26YIvATCm8nHOcVB6LcRIhs=; b=UBsUupS0oRarW8LH+x3YnzAjOF+OBoqLhgBm/Y1HWEjdTXJxDfZ2KG+JeBdnQ2cykt 2KFVdeck+VvaGI9jdXaZAMFj7gUPr4ipT3k+PYu2LIpC9BKf/6J9wXNHPo90SQqgjR0x R79oo0JEESS4PJ2IUGvoQosu4D2xDLcDxqDt2EgI1USseimSJHUmJu6oncsmPtTexRsB ldlDt1ICJaJn43dtTkBUVvA4TKwodfcvr2vKxurnQqCUwY3jwJ2yUh5hYtmkNv4i4fym 4Bs6wF5n9WAn+9iiE20CpoLKEq/uNZsv5rU8hc6vQllIUUFQ+SuOKdOQeeq0BKcFXej/ CeOg== X-Forwarded-Encrypted: i=1; AJvYcCWLSdSTR4HbqbNdEcu8qCqr1vnfHbn5v6pnuoBnLqIqlF6Gps7k+FdBYl9Dhsqw7Qq2JGN2Pdz8j7dL04s=@vger.kernel.org X-Gm-Message-State: AOJu0YyarbLclJ7WOXF61vYx12YE5b4fcwGjwVQKUpHSOipI3IMkTI58 E5P9b4YCST8Vz6loJoc2Enb45/UTz5S3KnN3HgYUbqs3zvflgoDFyxW3HQyPwM9BOQkp7bp5Ift ewCCKwn71uM8TvOEUXNvNlGqLJP3m0qJiMXB8kx+xsyoV5ZUabKduFnB2Vfv6AhpqFcE= X-Gm-Gg: ATEYQzzEPlzD8BrLHcaDhAF1Kj70iKRY/FlZ8yw7gzgByTMYuxTYnWWPmh0bknNShVB 8bZw0aaxYS6K2Vwq3pVemfBUsmPbEuu3werc0GBZTp2DE3+iBouEoGWcb/6rQ57N/osdsNeNCKs garbCYd4TCUEeBO3yVmrUbfomjHkGOhVWsPSPPaKiVsPHBySHkYk0KupD/CkzExly9mgVZISAWP GTinJwdHDOV+PAf52N3jV2C0Y5Ic8h19g4vnJrIQA+/FouM1mDa0kED38523lAzhOl3bH5fStZn Bd/0ohNnkPyfCct659+kf06hwa1zlzE8+S2BSkDqYwzknHl543EbjQC+5nnlHKxz6kfRAFeYW5e tYGAdv16WVFbjQmeGGtfjLMrx+5r0pI66G0cYCOS/ww4DgTeXwxE6aV/6+6AclmKWeg== X-Received: by 2002:a17:903:2f87:b0:2b0:41bf:ca83 with SMTP id d9443c01a7336-2b06e35b4c7mr33140775ad.23.1773839584307; Wed, 18 Mar 2026 06:13:04 -0700 (PDT) X-Received: by 2002:a17:903:2f87:b0:2b0:41bf:ca83 with SMTP id d9443c01a7336-2b06e35b4c7mr33140445ad.23.1773839583794; Wed, 18 Mar 2026 06:13:03 -0700 (PDT) Received: from [192.168.1.28] ([122.164.82.79]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e44a258sm27444125ad.34.2026.03.18.06.12.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 06:13:03 -0700 (PDT) Message-ID: <11471fb9-a862-41b9-95d1-68ddcca5b7a3@oss.qualcomm.com> Date: Wed, 18 Mar 2026 18:42:55 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/6] arm64: dts: qcom: add IPQ5210 SoC and rdp504 board support To: Konrad Dybcio , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel , Konrad Dybcio , Robert Marko , Guru Das Srinagesh , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org References: <20260318-ipq5210_boot_to_shell-v2-0-a87e27c37070@oss.qualcomm.com> <20260318-ipq5210_boot_to_shell-v2-5-a87e27c37070@oss.qualcomm.com> Content-Language: en-US From: Kathiravan Thirumoorthy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDExMiBTYWx0ZWRfX7JYPmJdpb4Vr xtW4ETciZyVc2X5HlhiPJ7JvodWSIt0PviAtmICvuNLR2+V+Dy3W2c65oXYEcBmjrw1z3Qv0pzf WT8JOvToOeI+dWr1oA4UXcHZifb29ZzxrtfFM6o9+wOvdRC5S+a/S0l/8uezxByl7OLofxZny5S DT427vVD3Fb6mSOkYABYqu+l14i3XKFkEnGf/mqWCChSLonvyQoT5obBRJ6xdlQbbWeiCHuz7OO raMRkSaHQ2IzOdLtj4/VyIORlfLCBq6HZUXJySm2YGGezGJEfsRObWbNJ0FBX9Lhtx6sQOOzt3/ /CQiNt287itEoWNWCLSmq67CfO54Gdqgqf3FF2x7YQ+pqs3N0Y9/XkMTarrT3h0/pEMiiddEMnB kW7tU5YFPN2F5ZALDT8D0p52E5xUd7AY+Ir8AmhAKqhGWTsVte7JGyhceWL20YeKlrT1YcFW+At DtQeMnNX93gKhF6O84w== X-Authority-Analysis: v=2.4 cv=Cd4FJbrl c=1 sm=1 tr=0 ts=69baa4e1 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=x8XZtM9IcEPKAfKvXv8PGA==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_K5XuSEh1TEqbUxoQ0s3:22 a=EUspDBNiAAAA:8 a=onala_4StLzjsFYz-ZEA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: C309aMYeake5kLlfYnasxxmqNAPIKN-D X-Proofpoint-GUID: C309aMYeake5kLlfYnasxxmqNAPIKN-D X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180112 On 3/18/2026 5:14 PM, Konrad Dybcio wrote: > On 3/18/26 9:39 AM, Kathiravan Thirumoorthy wrote: >> Add initial device tree support for the Qualcomm IPQ5210 SoC and >> rdp504 board. >> >> Signed-off-by: Kathiravan Thirumoorthy >> --- > [...] > >> +&sdhc { >> + max-frequency = <192000000>; >> + bus-width = <4>; >> + mmc-ddr-1_8v; >> + mmc-hs200-1_8v; >> + pinctrl-0 = <&sdhc_default_state>; >> + pinctrl-names = "default"; >> + status = "okay"; > nit: Please keep a uniform \n before 'status', file-wide Ack. I missed this to take care in RDP DTS. > > [...] > >> + cpus { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + cpu@0 { >> + device_type = "cpu"; >> + compatible = "arm,cortex-a53"; >> + reg = <0x0>; >> + enable-method = "psci"; >> + next-level-cache = <&l2_0>; > Since we have PSCI, is there some sort of cpuidle? Yeah, there is a plan to support but it is under development. Once it is available and validate, I will submit the incremental patches. > > [...] > >> + intc: interrupt-controller@b000000 { >> + compatible = "qcom,msm-qgic2"; >> + interrupt-controller; >> + #interrupt-cells = <3>; >> + reg = <0x0 0xb000000 0x0 0x1000>, /* GICD */ >> + <0x0 0xb002000 0x0 0x1000>, /* GICC */ >> + <0x0 0xb001000 0x0 0x1000>, /* GICH */ >> + <0x0 0xb004000 0x0 0x1000>; /* GICV */ > let's drop these comments Ack. > > [...] > >> + timer@b120000 { >> + compatible = "arm,armv7-timer-mem"; >> + reg = <0x0 0xb120000 0x0 0x1000>; > Please pad the address part of reg with leading zeroes to 8 hex digits > (i.e. 0x0b120000 etc.) Ack. Will take care of this next spin > > otherwise I think lgtm Thanks! > > Konrad