From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Daniel Walker <dwalker@mvista.com>
Cc: akpm@osdl.org, eokerson@quicknet.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] ixj gcc 4.1 warning fix
Date: Wed, 10 May 2006 11:40:36 +0100 [thread overview]
Message-ID: <1147257636.17886.11.camel@localhost.localdomain> (raw)
In-Reply-To: <200605100255.k4A2tx1b031712@dwalker1.mvista.com>
On Maw, 2006-05-09 at 19:55 -0700, Daniel Walker wrote:
> Fixes the following warnings,
>
> drivers/telephony/ixj.c: In function 'ixj_pstn_state':
> drivers/telephony/ixj.c:4847: warning: 'bytes.high' may be used uninitialized in this function
> drivers/telephony/ixj.c: In function 'ixj_write_frame':
> drivers/telephony/ixj.c:3448: warning: 'blankword.high' may be used uninitialized in this function
> drivers/telephony/ixj.c:3448: warning: 'blankword.low' may be used uninitialized in this function
>
> Signed-Off-By: Daniel Walker <dwalker@mvista.com>
No this is not a good idea either. The missing default case stuff is as
far as I can see from inspection not neccessary. If anything you want to
add
default:
BUG();
since those are impossible cases.
The unusued variables also appear to be just compiler confusion.
prev parent reply other threads:[~2006-05-10 10:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-10 2:55 Daniel Walker
2006-05-10 10:40 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147257636.17886.11.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=dwalker@mvista.com \
--cc=eokerson@quicknet.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®