mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel list <linux-kernel@vger.kernel.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Paul Mackerras <paulus@samba.org>, Andrew Morton <akpm@osdl.org>,
	Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC][PATCH] Cascaded interrupts: a simple solution
Date: Thu, 11 May 2006 16:13:43 +1000	[thread overview]
Message-ID: <1147328023.30380.59.camel@localhost.localdomain> (raw)
In-Reply-To: <1147325215.30380.45.camel@localhost.localdomain>


> Index: linux-work/kernel/irq/manage.c
> ===================================================================
> --- linux-work.orig/kernel/irq/manage.c	2006-05-11 11:45:09.000000000 +1000
> +++ linux-work/kernel/irq/manage.c	2006-05-11 12:00:52.000000000 +1000
> @@ -371,6 +371,13 @@ int request_irq(unsigned int irq,
>  	if (!handler)
>  		return -EINVAL;
>  
> +	/*
> +	 * SA_CASCADE implies SA_INTERRUPT (that is, the demux itself happens
> +	 * with interrupts disabled, the final handler is still called with
> +	 */
> +	if (irqflags & SA_CASCADEIRQ)
> +		irqflags |= SA_INTERRUPT;
> +

Oh and that bit isn't actually necessary ...

Ben.



  parent reply	other threads:[~2006-05-11  6:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-11  5:26 Benjamin Herrenschmidt
2006-05-11  5:41 ` [PATCH] PowerMac use of SA_CASCADEIRQ Benjamin Herrenschmidt
2006-05-11  6:13 ` Benjamin Herrenschmidt [this message]
2006-05-11  9:37 ` [RFC][PATCH] Cascaded interrupts: a simple solution Ingo Molnar
2006-05-11 11:47   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1147328023.30380.59.camel@localhost.localdomain \
    --to=benh@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®