From: Arjan van de Ven <arjan@infradead.org>
To: Jeff Garzik <jeff@garzik.org>
Cc: HighPoint Linux Team <linux@highpoint-tech.com>,
Andrew Morton <akpm@osdl.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver
Date: Mon, 15 May 2006 16:59:28 +0200 [thread overview]
Message-ID: <1147705188.3013.0.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <44682CDB.9080804@garzik.org>
On Mon, 2006-05-15 at 03:25 -0400, Jeff Garzik wrote:
> Arjan van de Ven wrote:
> > On Mon, 2006-05-15 at 14:22 +0800, HighPoint Linux Team wrote:
> >> Could you give more explanation about pci posting flush? When (and why) do we need it?
> >
> > pci posting is where the chipset internally delays (posts) writes (as
> > done by writel and such) to see if more writes will come that can then
> > be combined into one burst. While in practice these queues are finite
> > (and often have a timeout) it's bad practice to depend on that. The
> > simplest way to flush out this posting is to do a (dummy) readl() from
> > the same device. (alternative is to do dma from the device to ram, but
> > readl() is a lot easier ;)
> >
> >> In an old posting (http://lkml.org/lkml/2003/5/8/278) said pci posting flush is unnecessary - is it correct?
> >
> > no not really, not as a general statement.
>
> ACK.
>
> Generally speaking, readl() is the best way to ensure that all writes
> have been flushed across various layers of PCI bridges, etc.
>
> It is particularly important to get this right if you are issuing a
> delay (i.e. udelay) after a write. If the write is not guaranteed to be
> flushed at the time the delay begins, then you are no longer truly
> delaying for the time requested.
another typical case is at io submission or when you disable irqs in the
hardware..
next prev parent reply other threads:[~2006-05-15 15:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200605122209.k4CM95oW014664@mail.hypersurf.com>
2006-05-15 6:22 ` HighPoint Linux Team
2006-05-15 6:56 ` Arjan van de Ven
2006-05-15 7:25 ` Jeff Garzik
2006-05-15 14:59 ` Arjan van de Ven [this message]
2006-06-11 9:07 HighPoint Linux Team
2006-06-11 11:18 ` HighPoint Linux Team
2006-06-11 15:00 ` James Bottomley
2006-06-12 4:03 ` HighPoint Linux Team
2006-06-11 13:14 ` Jeff Garzik
2006-06-14 8:50 ` HighPoint Linux Team
[not found] <200605101704.27491.linux@highpoint-tech.com>
[not found] ` <200605121107.48597.linux@highpoint-tech.com>
2006-05-16 6:38 ` HighPoint Linux Team
2006-06-10 15:36 ` James Bottomley
2006-06-10 16:47 ` Andrew Morton
2006-06-10 18:11 ` James Bottomley
-- strict thread matches above, loose matches on Subject: below --
2006-05-09 22:02 Allen
2006-05-10 8:25 ` Christoph Hellwig
2006-05-10 10:47 ` Alan Cox
2006-05-12 20:32 ` Arjan van de Ven
2006-05-09 21:28 Allen
2006-05-09 21:59 ` Alexey Dobriyan
2006-05-09 22:34 ` Alexey Dobriyan
2006-05-09 22:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1147705188.3013.0.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@highpoint-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®