From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7BECFC77B61 for ; Thu, 13 Apr 2023 20:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229895AbjDMUkV (ORCPT ); Thu, 13 Apr 2023 16:40:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229493AbjDMUkR (ORCPT ); Thu, 13 Apr 2023 16:40:17 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1065E8685 for ; Thu, 13 Apr 2023 13:39:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681418372; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Quj1iiD9LgkSGI0NKmJzsno1BF3Rj6KCB6GiyGlg2P0=; b=i4FI52LlCl8aJnFnX1b3ulIR+ttzOKN601nbw1TRZaklJuBjQmve+2t2RioYze5jLwrVOw cuXDpeda4jtW+d6znOC9R8YVeDeKUhtFZ7rQIyuHozLOoIkzWsAKgUho5uK1YBbQhI8V9L HA9Ii9WlkJHe6ZsgYidRDYsHaAHkW1E= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-U6VXJyF_P7SHq6_28nlFzw-1; Thu, 13 Apr 2023 16:39:27 -0400 X-MC-Unique: U6VXJyF_P7SHq6_28nlFzw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA11C2814255; Thu, 13 Apr 2023 20:39:25 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.177]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6CA6340C6E70; Thu, 13 Apr 2023 20:39:23 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20230413042917.GA3390869@ZenIV> References: <20230413042917.GA3390869@ZenIV> <20230411160902.4134381-1-dhowells@redhat.com> <20230411160902.4134381-2-dhowells@redhat.com> <20230413005129.GZ3390869@ZenIV> To: Al Viro Cc: dhowells@redhat.com, netdev@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Willem de Bruijn , David Ahern , Matthew Wilcox , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Chuck Lever III , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Willem de Bruijn Subject: Re: [PATCH net-next v6 01/18] net: Declare MSG_SPLICE_PAGES internal sendmsg() flag MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1147765.1681418362.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Thu, 13 Apr 2023 21:39:22 +0100 Message-ID: <1147766.1681418362@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Al Viro wrote: > Note that io_sendmsg_prep() handles both IORING_OP_SENDMSG and IORING_OP= _SEND, > so this pair of functions can hit the same request. And sqe->msg_flags = is > not sanitized at all - it comes straight from user buffer. Assuming ____sys_sendmsg() is fixed, I think it should be sufficient to ma= ke io_send() and io_send_zc(). io_sendmsg() and io_sendmsg_zc() will go thro= ugh ____sys_sendmsg(). David