From: Arjan van de Ven <arjan@infradead.org>
To: David Chinner <dgc@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] Per-superblock unused dentry LRU lists.
Date: Wed, 24 May 2006 03:59:40 +0200 [thread overview]
Message-ID: <1148435980.3049.11.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060524012412.GB7412499@melbourne.sgi.com>
On Wed, 2006-05-24 at 11:24 +1000, David Chinner wrote:
> http://marc.theaimsgroup.com/?l=linux-kernel&m=114491661527656&w=2
>
> shrink_dcache_sb() becomes a severe bottleneck when the unused dentry
> list becomes long and mounts and unmounts occur frequently on the
> machine.
how does a per SB list deal with umounts that occur frequently? I
suppose it means destroying just your list...
> I've attempted to make reclaim fair by keeping track of the last superblock
> we pruned, and starting from the next on in the list each time.
how fair is this in the light of a non-equal sizes? say you have a 4Gb
fs and a 1Tb list. Will your approach result in trying to prune 1000
from the 4Gb, then 1000 from the 1Tb, then 1000 from the 4Gb etc ?
while that is fair in absolute terms, in relative terms it's highly not
fair to the small filesystem....
(I'm not sure there is ONE right answer here, well maybe by scaling the
count to the per fs count rather than to the total...)
this makes me wonder btw if we can do a per superblock slab for these
dentries, that may decrease fragmentation of slabs in combination with
your patch....
next prev parent reply other threads:[~2006-05-24 1:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-24 1:24 David Chinner
2006-05-24 1:44 ` Randy.Dunlap
2006-05-24 1:48 ` David Chinner
2006-05-24 1:59 ` Arjan van de Ven [this message]
2006-05-24 4:01 ` David Chinner
2006-05-24 4:23 ` Arjan van de Ven
2006-05-24 5:47 ` David Chinner
2006-05-24 5:02 ` Balbir Singh
2006-05-24 6:19 ` David Chinner
2006-05-24 7:06 ` Balbir Singh
2006-05-24 8:15 ` David Chinner
2006-05-24 8:28 ` Balbir Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148435980.3049.11.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=dgc@sgi.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®