From: Arjan van de Ven <arjan@infradead.org>
To: Greg KH <greg@kroah.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Tigran Aivazian <tigran@veritas.com>,
Rajesh Shah <rajesh.shah@intel.com>,
"Van De Ven, Arjan" <arjan@linux.intel.com>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2/2] microcode update driver rewrite
Date: Thu, 25 May 2006 06:16:37 +0200 [thread overview]
Message-ID: <1148530597.3052.27.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060525040557.GA30175@kroah.com>
On Wed, 2006-05-24 at 21:05 -0700, Greg KH wrote:
> On Thu, May 25, 2006 at 11:50:49AM +0800, Shaohua Li wrote:
> > This is the rewrite of microcode update driver. Changes:
> > 1. trim the code
>
> Hm, but the code is now bigger.
... because of the compat stuff. Maybe that should be split into a
separate file after some time.
> Don't use request_firmware, use request_firmware_nowait() instead. That
> way you never stall. You only want to update the firmware when
> userspace tells you to, not for every boot like I think this will do.
this isn't persistent firmware, it's microcode. That is volatile, to the
point that if you reboot (but that effect is also achieved at cpu S3 or
do cpu hotplug) you need to reload it. These types of events are
something the kernel knows about in general, but userspace.. not so.
(esp since you generally want to load microcode as early as possible)
next prev parent reply other threads:[~2006-05-25 4:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-25 3:50 Shaohua Li
2006-05-25 4:05 ` Greg KH
2006-05-25 4:12 ` Dave Jones
2006-05-25 15:02 ` Greg KH
2006-05-26 5:35 ` Arjan van de Ven
2006-05-25 4:16 ` Arjan van de Ven [this message]
2006-05-25 5:16 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1148530597.3052.27.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rajesh.shah@intel.com \
--cc=shaohua.li@intel.com \
--cc=tigran@veritas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®