From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965179AbWEaVoK (ORCPT ); Wed, 31 May 2006 17:44:10 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965181AbWEaVoJ (ORCPT ); Wed, 31 May 2006 17:44:09 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:9894 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S965179AbWEaVoH (ORCPT ); Wed, 31 May 2006 17:44:07 -0400 Subject: Re: [patch, -rc5-mm1] locking validator: special rule: 8390.c disable_irq() From: Arjan van de Ven To: Alan Cox Cc: Ingo Molnar , Andrew Morton , linux-kernel@vger.kernel.org In-Reply-To: <20060531214139.GA8196@devserv.devel.redhat.com> References: <20060531200236.GA31619@elte.hu> <1149107500.3114.75.camel@laptopd505.fenrus.org> <20060531214139.GA8196@devserv.devel.redhat.com> Content-Type: text/plain Date: Wed, 31 May 2006 23:43:58 +0200 Message-Id: <1149111838.3114.87.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2006-05-31 at 17:41 -0400, Alan Cox wrote: > On Wed, May 31, 2006 at 10:31:40PM +0200, Arjan van de Ven wrote: > > > 8390.c knows that ei_local->page_lock can only be used by an irq > > > context that it disabled - > > > > btw I think this is no longer correct with the irq polling stuff Alan > > added to the kernel recently... > > We could make the misrouted IRQ logic skip all handlers on a disabled IRQ > but that might actually be worse than the disease we are trying to cure by > doing so. yeah since misrouted irqs will cause the kernel do disable irqs 'at random' more or less .. for which the handlers now would become unreachable which isn't good.