From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750727AbWFEIBE (ORCPT ); Mon, 5 Jun 2006 04:01:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750731AbWFEIBE (ORCPT ); Mon, 5 Jun 2006 04:01:04 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:54718 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1750727AbWFEIBC (ORCPT ); Mon, 5 Jun 2006 04:01:02 -0400 Subject: Re: [PATCH] readahead: initial method - expected read size - fix fastcall From: Arjan van de Ven To: Voluspa Cc: wfg@mail.ustc.edu.cn, akpm@osdl.org, Valdis.Kletnieks@vt.edu, diegocg@gmail.com, linux-kernel@vger.kernel.org In-Reply-To: <20060605031720.0017ae5e.lista1@comhem.se> References: <349406446.10828@ustc.edu.cn> <20060604020738.31f43cb0.akpm@osdl.org> <1149413103.3109.90.camel@laptopd505.fenrus.org> <20060605031720.0017ae5e.lista1@comhem.se> Content-Type: text/plain Date: Mon, 05 Jun 2006 10:00:49 +0200 Message-Id: <1149494449.3111.0.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2006-06-05 at 03:17 +0200, Voluspa wrote: > On Sun, 04 Jun 2006 11:25:03 +0200 Arjan van de Ven wrote: > > On Sun, 2006-06-04 at 02:07 -0700, Andrew Morton wrote: > > > On Sun, 4 Jun 2006 15:34:15 +0800 > > > Fengguang Wu wrote: > > > > > > > Remove 'fastcall' directive for function readahead_close(). > > > > > > > > It has drawn concerns from Andrew Morton. > > > > > > Well. I think fastcall is ugly and vaguely silly. Now if we has a > > > really_really_fastcall then I'd like to use that! > > > > > > > > > > Now I have some benchmarks > > > > on it, and proved it as a _false_ optimization. > > > > > > Sorry, I don't believe this will be measurable (and with CONFIG_REGPARM > > > it'll be a no-op). > > > > we should just make CONFIG_REGPARM be "it" always (and thus make it go > > away as config option) and then just remove all "fastcall" from the > > kernel... > > Wu, I don't know anything about REGPARM, which my x86_64 config doesn't have, because it doesn't need it since it's default for that architecture