From: Eric Sesterhenn <snakebyte@gmx.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, mm@caldera.de
Subject: Re: [Patch] Check sound_alloc_mixerdev() failure in sound/oss/nm256_audio.c
Date: Mon, 05 Jun 2006 20:18:25 +0200 [thread overview]
Message-ID: <1149531505.15988.2.camel@alice> (raw)
In-Reply-To: <20060601170445.GA7265@martell.zuzino.mipt.ru>
hi,
> > - if (num_mixers >= MAX_MIXER_DEV) {
> > + if ((num_mixers >= MAX_MIXER_DEV) || (num_mixers < 0)) {
> ^^^^^^^^^^
> > printk ("NM256 mixer: Unable to alloc mixerdev\n");
> > return -1;
> > }
>
> But it is _still_ fails to check it.
*yuck* I hope you keep count on the numbers of beers i owe you
by now. Here is an updated patch.
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-rc5/sound/oss/nm256_audio.c.orig 2006-06-05 20:15:18.000000000 +0200
+++ linux-2.6.17-rc5/sound/oss/nm256_audio.c 2006-06-05 20:16:06.000000000 +0200
@@ -974,7 +974,7 @@ nm256_install_mixer (struct nm256_info *
return -1;
mixer = sound_alloc_mixerdev();
- if (num_mixers >= MAX_MIXER_DEV) {
+ if ((num_mixers >= MAX_MIXER_DEV) || (mixer < 0)) {
printk ("NM256 mixer: Unable to alloc mixerdev\n");
return -1;
}
prev parent reply other threads:[~2006-06-05 18:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 9:53 Eric Sesterhenn
2006-06-01 17:04 ` Alexey Dobriyan
2006-06-05 18:18 ` Eric Sesterhenn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149531505.15988.2.camel@alice \
--to=snakebyte@gmx.de \
--cc=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mm@caldera.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome