mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@linux.intel.com>
To: Jan Kara <jack@suse.cz>
Cc: Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>
Subject: Re: 2.6.17-rc5-mm3-lockdep - locking error in quotaon
Date: Mon, 05 Jun 2006 21:52:36 +0200	[thread overview]
Message-ID: <1149537156.3111.123.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060605193552.GB24342@atrey.karlin.mff.cuni.cz>


> following confuses the code (and I agree that it's kind of ugly from
> quota code to do that):
>   i_mutex of inode containing quota file is acquired after all other
> quota locks. i_mutex of all other inodes is acquired before quota locks.
> Quota code makes sure (by resetting inode operations and setting special
> flag on inode) that noone tries to enter quota code while holding
> i_mutex on a quota file...

can you point this out in a bit more detail, eg where exactly is this
happening? I think it is in this bit
       /* As we bypass the pagecache we must now flush the inode so that
         * we see all the changes from userspace... */
        write_inode_now(inode, 1);
        /* And now flush the block cache so that kernel sees the changes
*/
        invalidate_bdev(sb->s_bdev, 0);
        mutex_lock(&inode->i_mutex);
        mutex_lock(&dqopt->dqonoff_mutex);
        if (sb_has_quota_enabled(sb, type)) {
                error = -EBUSY;
                goto out_lock;

but that doesn't quite match your description...

  reply	other threads:[~2006-06-05 19:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-05 17:00 Valdis.Kletnieks
2006-06-05 17:25 ` Arjan van de Ven
2006-06-05 17:35   ` Jan Kara
2006-06-05 19:20   ` Valdis.Kletnieks
2006-06-05 19:35     ` Jan Kara
2006-06-05 19:52       ` Arjan van de Ven [this message]
2006-06-05 20:06         ` Jan Kara
2006-06-05 20:15           ` Ingo Molnar
2006-06-05 20:26           ` Arjan van de Ven
2006-06-06  2:22             ` Valdis.Kletnieks
2006-06-06  8:33             ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149537156.3111.123.camel@laptopd505.fenrus.org \
    --to=arjan@linux.intel.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@osdl.org \
    --cc=jack@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®