mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: John Richard Moser <nigelenki@comcast.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH][RFC] Clean-up:  TASK_UNMAPPED_BASE and mmap_base
Date: Thu, 08 Jun 2006 14:24:47 +0200	[thread overview]
Message-ID: <1149769487.3380.70.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <44862CE3.7040406@comcast.net>

On Tue, 2006-06-06 at 21:33 -0400, John Richard Moser wrote:
> This patch applies to 2.6.17-rc6 to replace several occurrences of
> TASK_UNMAPPED_BASE with current->mm->mmap_base, mm->mmap_base, or base,
> as appropriate.
> 
> I am not entirely sure what all of the code I messed with is doing, to
> be quite honest.  Code that seemed to be initializing a task and setting
> up the mmap() base I left with TASK_UNMAPPED_BASE; code that seemed to
> be trying to figure out what the mmap() base was I replaced with
> mm->mmap_base.
> 
> Because of this, I may have made a couple errors.  Could I get some
> comments on whether any of this is dirty and why?  I'll make appropriate
> changes and re-submit.  This only took 2 hours anyway.
> 

now if you put your patch inline you'd get comments in detail

but you missed that some of the places where this is used is the
fallback in case the per-task value doesnt result in a good memory hole
found.



  reply	other threads:[~2006-06-08 12:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-07  1:33 John Richard Moser
2006-06-08 12:24 ` Arjan van de Ven [this message]
2006-06-08 15:35   ` John Richard Moser
2006-06-08 16:02     ` Randy.Dunlap
2006-06-08 16:01       ` John Richard Moser
2006-06-08 16:09 ` [REPOST][PATCH][RFC] " John Richard Moser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149769487.3380.70.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nigelenki@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®