mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Russell King <rmk+lkml@arm.linux.org.uk>
Cc: Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] genirq: Fix missing initializer for unmask in no_irq_chip
Date: Thu, 08 Jun 2006 17:58:12 +0200	[thread overview]
Message-ID: <1149782293.5257.43.camel@localhost.localdomain> (raw)
In-Reply-To: <20060608152926.GA15337@flint.arm.linux.org.uk>

On Thu, 2006-06-08 at 16:29 +0100, Russell King wrote:
> > > This doesn't happen with the ARM IRQ subsystem because the "no chip"
> > > handlers are all pointing at a dummy function instead of being NULL.
> > > Could we do the same with genirq ?
> > 
> > We missed to initialize unmask, which causes problems on neponset.
> 
> Okay, with -rc6 + genirq + the following patch,

I uploaded proper fixups for those:
http://tglx.de/projects/armirq/2.6.17-rc6/patch-2.6.17-rc6-armirq3.patches.tar.bz2

>  it appears to work
> provided you don't stress it.  As soon as I load the system up with
> CF activity, a full-sized flood ping and hit "enter" a few times on
> the console, it locks up solid - no oops, no nothing, the machine
> just completely freezes.
> 
> This does not happen with the existing ARM IRQ code.
> 
> I'll try to debug this odd behaviour later today, but first I need to
> resurect my NMI oopser code for this platform.

Thanks,

	tglx



  reply	other threads:[~2006-06-08 15:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-17  0:13 [patch 00/50] genirq: -V3 Ingo Molnar
2006-05-17  6:11 ` Benjamin Herrenschmidt
2006-05-17 22:27   ` Russell King
2006-05-18  0:32     ` Benjamin Herrenschmidt
2006-05-18  7:38       ` Russell King
2006-05-18  9:33         ` Benjamin Herrenschmidt
2006-05-17 22:15 ` [patchset] Generic IRQ Subsystem: -V4 Ingo Molnar
2006-05-18 22:24   ` Ingo Oeser
2006-05-19  9:31     ` Ingo Molnar
2006-05-19 17:00       ` Ingo Oeser
2006-05-19 14:52   ` [patchset] Generic IRQ Subsystem: -V5 Ingo Molnar
2006-06-07 16:54     ` Russell King
2006-06-07 17:20       ` Thomas Gleixner
2006-06-07 18:57         ` Thomas Gleixner
2006-06-08 11:35           ` Russell King
2006-06-08 12:04             ` [PATCH] genirq: Fix missing initializer for unmask in no_irq_chip Thomas Gleixner
2006-06-08 15:29               ` Russell King
2006-06-08 15:58                 ` Thomas Gleixner [this message]
2006-06-08 18:57                   ` Thomas Gleixner
2006-06-08 22:32                     ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1149782293.5257.43.camel@localhost.localdomain \
    --to=tglx@linutronix.de \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=rmk+lkml@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome