From: James Bottomley <James.Bottomley@SteelEye.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Andrew Morton <akpm@osdl.org>, Jens Axboe <axboe@suse.de>,
Kernel development list <linux-kernel@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/3] SCSI core and sd: early detection of medium not present
Date: Thu, 08 Jun 2006 19:57:46 -0500 [thread overview]
Message-ID: <1149814666.3276.16.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0606061126540.9182-100000@iolanthe.rowland.org>
On Tue, 2006-06-06 at 11:31 -0400, Alan Stern wrote:
> This patch (as695) changes the scsi_test_unit_ready() routine in the
> SCSI
> core to set a new flag when no medium is present. The sd driver is
> changed to use this new flag for reporting -ENOMEDIUM in from the
> sd_media_changed method.
This would appear to be duplicating the struct scsi_disk media_present
flag. Moving the media_present flag from scsi_disk to scsi_device may
make a bit of sense long term ... however, there's also dupication with
the sr driver and the cdrom layer now (that stores media change at the
cdrom level), so is there an argument why it's better in scsi_device
than scsi_disk?
James
next prev parent reply other threads:[~2006-06-09 3:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-06 15:31 Alan Stern
2006-06-09 0:57 ` James Bottomley [this message]
2006-06-09 14:13 ` Alan Stern
2006-06-09 14:28 ` James Bottomley
2006-06-09 14:54 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1149814666.3276.16.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®