From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24D1C0502E for ; Mon, 29 Aug 2022 02:37:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229609AbiH2Chl (ORCPT ); Sun, 28 Aug 2022 22:37:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229453AbiH2Chj (ORCPT ); Sun, 28 Aug 2022 22:37:39 -0400 Received: from mailgw01.mediatek.com (unknown [60.244.123.138]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 676CA3C8E6; Sun, 28 Aug 2022 19:37:35 -0700 (PDT) X-UUID: 9f87e7b61458457d868f169ed8cc0cc4-20220829 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=pMxL4qDPpxQ5G6XsiawgSYIMi9de2EXDfLP+YzVPj3Q=; b=AJYf630YX9H+iJkopq1LZhD1UEA2TWo6ZTeeH2y+KtBzvFqV/KmJ1HRzfMXAYFSn5hY4K6cT+qKEB8RXRjKu9dEgbhI6G6rqB47+bnRG1uWbE/netN40BmswAJ2ZBy/sVMWVXWlwZ52RrWm+WRyIvsvBfazcgMiUd4GUARsd/zE=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.10,REQID:01446251-077a-4ceb-b61f-1c498d690dc6,OB:0,L OB:0,IP:0,URL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_ Ham,ACTION:release,TS:0 X-CID-META: VersionHash:84eae18,CLOUDID:44395d20-1c20-48a5-82a0-25f9c331906d,C OID:IGNORED,Recheck:0,SF:nil,TC:nil,Content:0,EDM:-3,IP:nil,URL:11|1,File: nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 9f87e7b61458457d868f169ed8cc0cc4-20220829 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw01.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 289164118; Mon, 29 Aug 2022 10:37:30 +0800 Received: from mtkcas10.mediatek.inc (172.21.101.39) by mtkmbs11n2.mediatek.inc (172.21.101.187) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.15; Mon, 29 Aug 2022 10:37:29 +0800 Received: from mhfsdcap04 (10.17.3.154) by mtkcas10.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 29 Aug 2022 10:37:28 +0800 Message-ID: <114c357f8d7f049d21ede789a292a8e2d45f4c61.camel@mediatek.com> Subject: Re: [PATCH 2/7] dt-bindings: phy: mediatek,tphy: add property to set pre-emphasis From: Chunfeng Yun To: Krzysztof Kozlowski , Vinod Koul , Rob Herring CC: Kishon Vijay Abraham I , Krzysztof Kozlowski , Matthias Brugger , , , , , , Eddie Hung Date: Mon, 29 Aug 2022 10:37:28 +0800 In-Reply-To: <000babd8-5980-3d77-f156-324b3442cbe7@linaro.org> References: <20220819091344.2274-1-chunfeng.yun@mediatek.com> <20220819091344.2274-2-chunfeng.yun@mediatek.com> <438da392-f419-ad76-7e91-aa4aab36e12c@linaro.org> <816ecf6287533137b750c8bde9de5830e4229c56.camel@mediatek.com> <1a16cce9fe164bafc06ae193310be71c6f645d75.camel@mediatek.com> <000babd8-5980-3d77-f156-324b3442cbe7@linaro.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-08-26 at 09:36 +0300, Krzysztof Kozlowski wrote: > On 26/08/2022 08:36, Chunfeng Yun wrote: > > On Tue, 2022-08-23 at 13:24 +0300, Krzysztof Kozlowski wrote: > > > On 22/08/2022 10:07, Chunfeng Yun wrote: > > > > On Fri, 2022-08-19 at 15:15 +0300, Krzysztof Kozlowski wrote: > > > > > On 19/08/2022 12:13, Chunfeng Yun wrote: > > > > > > Add a property to set usb2 phy's pre-emphasis. > > > > > > > > > > > > Signed-off-by: Chunfeng Yun > > > > > > --- > > > > > > Documentation/devicetree/bindings/phy/mediatek,tphy.yaml | > > > > > > 7 > > > > > > +++++++ > > > > > > 1 file changed, 7 insertions(+) > > > > > > > > > > > > diff --git > > > > > > a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > > > > b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > > > > index 848edfb1f677..aee2f3027371 100644 > > > > > > --- > > > > > > a/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > > > > +++ > > > > > > b/Documentation/devicetree/bindings/phy/mediatek,tphy.yaml > > > > > > @@ -219,6 +219,13 @@ patternProperties: > > > > > > minimum: 1 > > > > > > maximum: 15 > > > > > > > > > > > > + mediatek,pre-emphasis: > > > > > > + description: > > > > > > + The selection of pre-emphasis (U2 phy) > > > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > > > + minimum: 1 > > > > > > + maximum: 3 > > > > > > > > > > Instead of hard-coding register values in bindings, you > > > > > should > > > > > rather > > > > > describe here feature/effect. If it is in units, use unit > > > > > suffixes. > > > > > If > > > > > it is some choice, usually string enum is appropriate. > > > > > > > > How about changing description as bellow: > > > > > > > > "The level of pre-emphasis, increases one level, boosts the > > > > relative > > > > amplitudes of signal's higher frequencies components about > > > > 4.16% > > > > (U2 > > > > phy)" > > > > > > > > > > Still the question is what is the unit. 4.16%? > > > > No unit, it's a level value, like an index of array. > > > > So a value from register/device programming? Yes > Rather a regular units > should be used if that's possible. If not, this should be clearly > described here, not some magical number which you encode into DTS... Ok, I'll add more descriptions. Thanks a lot > > Best regards, > Krzysztof