mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Voluspa <lista1@comhem.se>,
	linux-kernel@vger.kernel.org, akpm <akpm@osdl.org>,
	len.brown@intel.com
Subject: Re: [UBUNTU:acpi/ec] Use semaphore instead of spinlock
Date: Thu, 15 Jun 2006 17:40:59 +0200	[thread overview]
Message-ID: <1150386059.2987.5.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <4490B48E.5060304@oracle.com>

On Wed, 2006-06-14 at 18:14 -0700, Randy Dunlap wrote:
> updated version:
> 
> From: Ben Collins <bcollins@ubuntu.com>
> 
> [UBUNTU:acpi/ec] Use semaphore instead of spinlock to get rid of missed
> interrupts on ACPI EC (embedded controller)


that is odd.

first of all this should use a mutex not a semaphore.

Second, if this isn't used in irq context, then just dropping the
"_irqsave" from the spinlocks should be enough to actually get rid of
the missed interrupts.... and if it is used there then I highly question
your use of semaphores etc...


  parent reply	other threads:[~2006-06-16  0:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-14 23:08 Voluspa
2006-06-15  0:26 ` Randy Dunlap
2006-06-15  1:14 ` Randy Dunlap
2006-06-15  5:45   ` Roland Dreier
2006-06-15 11:03   ` Voluspa
2006-06-15 16:27     ` Lee Revell
2006-06-16  9:23       ` Voluspa
2006-06-17  2:57         ` Lee Revell
2006-06-15 15:40   ` Arjan van de Ven [this message]
2006-06-14 23:22 Randy Dunlap
2006-06-15  5:38 ` Bongani Hlope
2006-06-20  0:40   ` Andrew Morton
2006-06-20  0:41     ` Randy Dunlap
2006-06-20  1:10       ` Andrew Morton
2006-06-16 14:31 ` Luiz Fernando N. Capitulino
2006-06-16 17:43   ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150386059.2987.5.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lista1@comhem.se \
    --cc=randy.dunlap@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®