mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Roland McGrath <roland@redhat.com>,
	Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@elte.hu>,
	Steven Rostedt <rostedt@goodmis.org>,
	Chris Wright <chrisw@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] posix cpu timers fixes
Date: Thu, 15 Jun 2006 12:48:14 -0700	[thread overview]
Message-ID: <1150400894.15267.16.camel@cog.beaverton.ibm.com> (raw)
In-Reply-To: <20060615160931.GA21450@oleg>

On Thu, 2006-06-15 at 20:09 +0400, Oleg Nesterov wrote:
> John Stultz hit run_posix_cpu_timers()->BUG_ON(tsk->exit_state), see
> 
> 	http://marc.theaimsgroup.com/?l=linux-kernel&m=115015841413687
> 
> This was fixed by
> 
> 	Commit 3de463c7d9d58f8cf3395268230cb20a4c15bffa
> 	[PATCH] posix-timers: remove false BUG_ON() from run_posix_cpu_timers()
> 	(now re-sended as [PATCH 2/3])
> 
> but it was reverted because it triggered a problem,

Again, just to be clear, I only hit the BUG_ON when using the -RT tree,
which is likely due to the fact that run_posix_cpu_timers() runs from a
kernel thread rather then interrupt context (thus tsk is not current and
you're more likely to race against an exiting task).

It may very well be the issue applies to mainline as well, but I just
want to make sure the proper caution is taken.


> With these patches applied Chris's program exits without any problems.
> 
> John, could you please try these patches while you are testing posix
> cpu timers?

I will give them a go. Some of them are already in the -rt tree, as they
were triggered early on.

thanks
-john


      reply	other threads:[~2006-06-15 19:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 16:09 Oleg Nesterov
2006-06-15 19:48 ` john stultz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1150400894.15267.16.camel@cog.beaverton.ibm.com \
    --to=johnstul@us.ibm.com \
    --cc=akpm@osdl.org \
    --cc=chrisw@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®