From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Arnd Bergmann <arnd.bergmann@de.ibm.com>,
Linus Torvalds <torvalds@osdl.org>
Subject: Re: [PATCH] powerpc: enable CPU_FTR_CI_LARGE_PAGE for cell
Date: Sun, 18 Jun 2006 08:29:10 +1000 [thread overview]
Message-ID: <1150583350.23600.117.camel@localhost.localdomain> (raw)
In-Reply-To: <200606171759.k5HHxkjG004420@hera.kernel.org>
On Sat, 2006-06-17 at 17:59 +0000, Linux Kernel Mailing List wrote:
> commit ce221982e0bef039d7047b0f667bb414efece5af
> tree fa01b712522338d3f19ee5a6fedace7b7149c430
> parent 19242b240793ac769f5b91b68a5e43dd39f0c530
> author Arnd Bergmann <arnd.bergmann@de.ibm.com> Thu, 15 Jun 2006 15:09:16 +0200
> committer Linus Torvalds <torvalds@g5.osdl.org> Sun, 18 Jun 2006 00:56:24 -0700
>
> [PATCH] powerpc: enable CPU_FTR_CI_LARGE_PAGE for cell
>
> Reflect the fact that the Cell Broadband Engine supports 64k
> pages by adding the bit to the CPU features.
Are you sure you want that in ? The SPU code upstream isn't ready for
64k pages yet... I spotted at least:
__spu_trap_data_seg() and get_kernel_slb()
Those need to encode the proper page size. I think you have patches for
that already. I wouldn't enable 64k pages with the abvoe without these
as you may end up with infinite hash fault loops due to the mismatch
between page size encoding in the hash table an in the SLB.
Ben.
next parent reply other threads:[~2006-06-17 22:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606171759.k5HHxkjG004420@hera.kernel.org>
2006-06-17 22:29 ` Benjamin Herrenschmidt [this message]
2006-06-18 2:10 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150583350.23600.117.camel@localhost.localdomain \
--to=benh@kernel.crashing.org \
--cc=arnd.bergmann@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®