From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: gouji <gouji.masayuki@jp.fujitsu.com>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>
Subject: Re: About the fixes of /drivers/serial/8250.C in 2.6.17-rc6 for avoiding habbg-up
Date: Mon, 19 Jun 2006 10:23:14 +0100 [thread overview]
Message-ID: <1150708994.2503.3.camel@localhost.localdomain> (raw)
In-Reply-To: <000d01c6934c$f25c9870$f4647c0a@GOUJI>
Ar Llu, 2006-06-19 am 12:03 +0900, ysgrifennodd gouji:
> In /drivers/serial/8250.C of 2.6.17-rc6,
>
> these fixes are adapted for avoinding the problem of hang-up
> while TTY write and console write from kernel conflicted.
Yes, there is a bug in this version that was not in the one I submitted,
someone added an improvement.
> + if (oops_in_progress) {
> + locked = spin_trylock_irqsave(&up->port.lock, flags);
> + } else
> + spin_lock_irqsave(&up->port.lock, flags);
> +
It could always use spin_trylock_irqsave(). The oops in progress
optimisation makes some sense initially but there are many console
printk users that can occur during serial I/O in exceptional cases.
It's not an easy problem to solve with the current serial locking.
Alan
next parent reply other threads:[~2006-06-19 9:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <000d01c6934c$f25c9870$f4647c0a@GOUJI>
2006-06-19 9:23 ` Alan Cox [this message]
2006-06-19 9:32 ` Russell King
2006-06-19 10:31 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150708994.2503.3.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=gouji.masayuki@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome